blob: 92061f3c2dc601101a217efc1999dddc6b66a877 [file] [log] [blame]
Colin Cross3f40fa42015-01-30 17:27:36 -08001package cc
2
3import (
4 "sort"
5 "strings"
6)
7
8// Cflags that should be filtered out when compiling with clang
9var clangUnknownCflags = []string{
10 "-finline-functions",
11 "-finline-limit=64",
12 "-fno-canonical-system-headers",
Dan Willemsen3bf6b472015-09-11 17:41:10 -070013 "-Wno-clobbered",
14 "-fno-devirtualize",
Colin Cross3f40fa42015-01-30 17:27:36 -080015 "-fno-tree-sra",
Colin Crossa360e8b2015-03-16 16:22:28 -070016 "-fprefetch-loop-arrays",
Colin Cross3f40fa42015-01-30 17:27:36 -080017 "-funswitch-loops",
18 "-Wmaybe-uninitialized",
Dan Willemsen3bf6b472015-09-11 17:41:10 -070019 "-Wno-error=clobbered",
Colin Cross3f40fa42015-01-30 17:27:36 -080020 "-Wno-error=maybe-uninitialized",
Colin Cross74d1ec02015-04-28 13:30:13 -070021 "-Wno-error=unused-but-set-parameter",
22 "-Wno-error=unused-but-set-variable",
Colin Cross3f40fa42015-01-30 17:27:36 -080023 "-Wno-free-nonheap-object",
24 "-Wno-literal-suffix",
25 "-Wno-maybe-uninitialized",
26 "-Wno-old-style-declaration",
27 "-Wno-psabi",
Colin Cross3f40fa42015-01-30 17:27:36 -080028 "-Wno-unused-but-set-parameter",
Colin Cross74d1ec02015-04-28 13:30:13 -070029 "-Wno-unused-but-set-variable",
Colin Cross3f40fa42015-01-30 17:27:36 -080030 "-Wno-unused-local-typedefs",
Colin Cross62ec5f42015-03-18 17:20:28 -070031 "-Wunused-but-set-parameter",
Colin Cross74d1ec02015-04-28 13:30:13 -070032 "-Wunused-but-set-variable",
Colin Cross3f40fa42015-01-30 17:27:36 -080033
34 // arm + arm64 + mips + mips64
35 "-fgcse-after-reload",
36 "-frerun-cse-after-loop",
37 "-frename-registers",
38 "-fno-strict-volatile-bitfields",
39
40 // arm + arm64
41 "-fno-align-jumps",
42 "-Wa,--noexecstack",
43
44 // arm
45 "-mthumb-interwork",
46 "-fno-builtin-sin",
47 "-fno-caller-saves",
48 "-fno-early-inlining",
49 "-fno-move-loop-invariants",
50 "-fno-partial-inlining",
51 "-fno-tree-copy-prop",
52 "-fno-tree-loop-optimize",
53
54 // mips + mips64
55 "-msynci",
Dan Willemsen3bf6b472015-09-11 17:41:10 -070056 "-mno-synci",
Colin Cross3f40fa42015-01-30 17:27:36 -080057 "-mno-fused-madd",
58
59 // x86 + x86_64
60 "-finline-limit=300",
61 "-fno-inline-functions-called-once",
62 "-mfpmath=sse",
63 "-mbionic",
64}
65
66func init() {
67 sort.Strings(clangUnknownCflags)
68
69 pctx.StaticVariable("clangExtraCflags", strings.Join([]string{
70 "-D__compiler_offsetof=__builtin_offsetof",
71
72 // Help catch common 32/64-bit errors.
73 "-Werror=int-conversion",
74
Colin Cross74d1ec02015-04-28 13:30:13 -070075 // Disable overly aggressive warning for macros defined with a leading underscore
76 // This happens in AndroidConfig.h, which is included nearly everywhere.
Dan Willemsen3bf6b472015-09-11 17:41:10 -070077 // TODO: can we remove this now?
Colin Cross74d1ec02015-04-28 13:30:13 -070078 "-Wno-reserved-id-macro",
79
80 // Disable overly aggressive warning for format strings.
81 // Bug: 20148343
82 "-Wno-format-pedantic",
83
Colin Cross3f40fa42015-01-30 17:27:36 -080084 // Workaround for ccache with clang.
85 // See http://petereisentraut.blogspot.com/2011/05/ccache-and-clang.html.
86 "-Wno-unused-command-line-argument",
87
88 // Disable -Winconsistent-missing-override until we can clean up the existing
89 // codebase for it.
90 "-Wno-inconsistent-missing-override",
91 }, " "))
92
93 pctx.StaticVariable("clangExtraConlyflags", strings.Join([]string{
94 "-std=gnu99",
95 }, " "))
96
97 pctx.StaticVariable("clangExtraTargetCflags", strings.Join([]string{
98 "-nostdlibinc",
99 }, " "))
100}
101
102func clangFilterUnknownCflags(cflags []string) []string {
103 ret := make([]string, 0, len(cflags))
104 for _, f := range cflags {
105 if !inListSorted(f, clangUnknownCflags) {
106 ret = append(ret, f)
107 }
108 }
109
110 return ret
111}
112
113func inListSorted(s string, list []string) bool {
114 for _, l := range list {
115 if s == l {
116 return true
117 } else if s < l {
118 return false
119 }
120 }
121 return false
122}