blob: 6a0aa8f417268302721bac4158f8d1462c8c40ec [file] [log] [blame]
Colin Cross30e076a2015-04-13 13:58:27 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17// This file contains the module types for compiling Android apps.
18
19import (
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070020 "path/filepath"
21 "reflect"
Jaewoong Jung5b425e22019-06-17 17:40:56 -070022 "sort"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070023 "strings"
Colin Cross30e076a2015-04-13 13:58:27 -070024
Colin Cross50ddcc42019-05-16 12:28:22 -070025 "github.com/google/blueprint"
26 "github.com/google/blueprint/proptools"
27
Colin Cross635c3b02016-05-18 15:37:25 -070028 "android/soong/android"
Colin Crossa4f08812018-10-02 22:03:40 -070029 "android/soong/cc"
Colin Cross303e21f2018-08-07 16:49:25 -070030 "android/soong/tradefed"
Colin Cross30e076a2015-04-13 13:58:27 -070031)
32
Jaewoong Jung3e18b192019-06-11 12:25:34 -070033var supportedDpis = []string{"ldpi", "mdpi", "hdpi", "xhdpi", "xxhdpi", "xxxhdpi"}
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070034
Colin Cross3bc7ffa2017-11-22 16:19:37 -080035func init() {
Paul Duffinf9b1da02019-12-18 19:51:55 +000036 RegisterAppBuildComponents(android.InitRegistrationContext)
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -070037
38 initAndroidAppImportVariantGroupTypes()
Colin Cross3bc7ffa2017-11-22 16:19:37 -080039}
40
Paul Duffinf9b1da02019-12-18 19:51:55 +000041func RegisterAppBuildComponents(ctx android.RegistrationContext) {
42 ctx.RegisterModuleType("android_app", AndroidAppFactory)
43 ctx.RegisterModuleType("android_test", AndroidTestFactory)
44 ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
45 ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
46 ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
47 ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
48 ctx.RegisterModuleType("android_app_import", AndroidAppImportFactory)
49 ctx.RegisterModuleType("android_test_import", AndroidTestImportFactory)
Jaewoong Jung9befb0c2020-01-18 10:33:43 -080050 ctx.RegisterModuleType("runtime_resource_overlay", RuntimeResourceOverlayFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +000051}
52
Colin Cross30e076a2015-04-13 13:58:27 -070053// AndroidManifest.xml merging
54// package splits
55
Colin Crossfabb6082018-02-20 17:22:23 -080056type appProperties struct {
Colin Crossbd01e2a2018-10-04 15:21:03 -070057 // Names of extra android_app_certificate modules to sign the apk with in the form ":module".
Colin Cross7d5136f2015-05-11 13:39:40 -070058 Additional_certificates []string
59
60 // If set, create package-export.apk, which other packages can
61 // use to get PRODUCT-agnostic resource data like IDs and type definitions.
Nan Zhangea568a42017-11-08 21:20:04 -080062 Export_package_resources *bool
Colin Cross7d5136f2015-05-11 13:39:40 -070063
Colin Cross16056062017-12-13 22:46:28 -080064 // Specifies that this app should be installed to the priv-app directory,
65 // where the system will grant it additional privileges not available to
66 // normal apps.
67 Privileged *bool
Colin Crossa97c5d32018-03-28 14:58:31 -070068
69 // list of resource labels to generate individual resource packages
70 Package_splits []string
Jason Monkd4122be2018-08-10 09:33:36 -040071
72 // Names of modules to be overridden. Listed modules can only be other binaries
73 // (in Make or Soong).
74 // This does not completely prevent installation of the overridden binaries, but if both
75 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
76 // from PRODUCT_PACKAGES.
77 Overrides []string
Colin Crossa4f08812018-10-02 22:03:40 -070078
79 // list of native libraries that will be provided in or alongside the resulting jar
80 Jni_libs []string `android:"arch_variant"`
81
Colin Crossee87c602020-02-19 16:57:15 -080082 // if true, allow JNI libraries that link against platform APIs even if this module sets
83 // sdk_version.
84 Jni_uses_platform_apis *bool
85
Jaewoong Jungbc625cd2019-05-06 15:48:44 -070086 // STL library to use for JNI libraries.
87 Stl *string `android:"arch_variant"`
88
Colin Crosse4246ab2019-02-05 21:55:21 -080089 // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
90 // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
Jiyong Park52cd06f2019-11-11 10:14:32 +090091 // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
92 // android_app modules that are embedded to APEXes, defaults to false for other module types where the native
93 // libraries are generally preinstalled outside the APK.
Colin Crosse4246ab2019-02-05 21:55:21 -080094 Use_embedded_native_libs *bool
Colin Cross46abdad2019-02-07 13:07:08 -080095
96 // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
97 // they are used from inside the APK at runtime.
98 Use_embedded_dex *bool
Colin Cross47fa9d32019-03-26 10:51:39 -070099
100 // Forces native libraries to always be packaged into the APK,
101 // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
102 // True for android_test* modules.
103 AlwaysPackageNativeLibs bool `blueprint:"mutated"`
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700104
105 // If set, find and merge all NOTICE files that this module and its dependencies have and store
106 // it in the APK as an asset.
107 Embed_notices *bool
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700108
109 // cc.Coverage related properties
110 PreventInstall bool `blueprint:"mutated"`
111 HideFromMake bool `blueprint:"mutated"`
112 IsCoverageVariant bool `blueprint:"mutated"`
Colin Cross7d5136f2015-05-11 13:39:40 -0700113}
114
Jaewoong Jung525443a2019-02-28 15:35:54 -0800115// android_app properties that can be overridden by override_android_app
116type overridableAppProperties struct {
117 // The name of a certificate in the default certificate directory, blank to use the default product certificate,
118 // or an android_app_certificate module name in the form ":module".
119 Certificate *string
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700120
121 // the package name of this app. The package name in the manifest file is used if one was not given.
122 Package_name *string
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800123
124 // the logging parent of this app.
125 Logging_parent *string
Jaewoong Jung525443a2019-02-28 15:35:54 -0800126}
127
Colin Cross30e076a2015-04-13 13:58:27 -0700128type AndroidApp struct {
Colin Crossa97c5d32018-03-28 14:58:31 -0700129 Library
130 aapt
Jaewoong Jung525443a2019-02-28 15:35:54 -0800131 android.OverridableModuleBase
Colin Crossa97c5d32018-03-28 14:58:31 -0700132
Colin Cross50ddcc42019-05-16 12:28:22 -0700133 usesLibrary usesLibrary
134
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900135 certificate Certificate
Colin Cross30e076a2015-04-13 13:58:27 -0700136
Colin Crossfabb6082018-02-20 17:22:23 -0800137 appProperties appProperties
Colin Crossae5caf52018-05-22 11:11:52 -0700138
Jaewoong Jung525443a2019-02-28 15:35:54 -0800139 overridableAppProperties overridableAppProperties
140
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700141 installJniLibs []jniLib
142 jniCoverageOutputs android.Paths
Colin Crossf6237212018-10-29 23:14:58 -0700143
144 bundleFile android.Path
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800145
146 // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
147 installApkName string
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800148
Colin Cross70dda7e2019-10-01 22:05:35 -0700149 installDir android.InstallPath
Jaewoong Jung0949f312019-09-11 10:25:18 -0700150
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700151 onDeviceDir string
152
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800153 additionalAaptFlags []string
Jaewoong Jung98772792019-07-01 17:15:13 -0700154
155 noticeOutputs android.NoticeOutputs
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900156
157 overriddenManifestPackageName string
Colin Crosse1731a52017-12-14 11:22:55 -0800158}
159
Martin Stjernholm6d415272020-01-31 17:10:36 +0000160func (a *AndroidApp) IsInstallable() bool {
161 return Bool(a.properties.Installable)
162}
163
Colin Cross89c31582018-04-30 15:55:11 -0700164func (a *AndroidApp) ExportedProguardFlagFiles() android.Paths {
165 return nil
166}
167
Colin Cross66f78822018-05-02 12:58:28 -0700168func (a *AndroidApp) ExportedStaticPackages() android.Paths {
169 return nil
170}
171
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900172func (a *AndroidApp) OutputFile() android.Path {
173 return a.outputFile
174}
175
Colin Cross503c1d02020-01-28 14:00:53 -0800176func (a *AndroidApp) Certificate() Certificate {
177 return a.certificate
178}
179
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700180func (a *AndroidApp) JniCoverageOutputs() android.Paths {
181 return a.jniCoverageOutputs
182}
183
Colin Crossa97c5d32018-03-28 14:58:31 -0700184var _ AndroidLibraryDependency = (*AndroidApp)(nil)
185
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900186type Certificate struct {
Colin Cross503c1d02020-01-28 14:00:53 -0800187 Pem, Key android.Path
188 presigned bool
189}
190
191var presignedCertificate = Certificate{presigned: true}
192
193func (c Certificate) AndroidMkString() string {
194 if c.presigned {
195 return "PRESIGNED"
196 } else {
197 return c.Pem.String()
198 }
Colin Cross30e076a2015-04-13 13:58:27 -0700199}
200
Colin Cross46c9b8b2017-06-22 16:51:17 -0700201func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
202 a.Module.deps(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700203
Jiyong Park6a927c42020-01-21 02:03:43 +0900204 if String(a.appProperties.Stl) == "c++_shared" && !a.sdkVersion().specified() {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700205 ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
206 }
207
Paul Duffin250e6192019-06-07 10:44:37 +0100208 sdkDep := decodeSdkDep(ctx, sdkContext(a))
209 if sdkDep.hasFrameworkLibs() {
210 a.aapt.deps(ctx, sdkDep)
Colin Cross30e076a2015-04-13 13:58:27 -0700211 }
Colin Crossa4f08812018-10-02 22:03:40 -0700212
Peter Collingbournead84f972019-12-17 16:46:18 -0800213 tag := &jniDependencyTag{}
Colin Crossa4f08812018-10-02 22:03:40 -0700214 for _, jniTarget := range ctx.MultiTargets() {
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700215 variation := append(jniTarget.Variations(),
216 blueprint.Variation{Mutator: "link", Variation: "shared"})
Colin Crossc511bc52020-04-07 16:50:32 +0000217
218 // If the app builds against an Android SDK use the SDK variant of JNI dependencies
219 // unless jni_uses_platform_apis is set.
220 if a.sdkVersion().specified() && a.sdkVersion().kind != sdkCorePlatform &&
221 !Bool(a.appProperties.Jni_uses_platform_apis) {
222 variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
223 }
Colin Crossa4f08812018-10-02 22:03:40 -0700224 ctx.AddFarVariationDependencies(variation, tag, a.appProperties.Jni_libs...)
225 }
Colin Cross50ddcc42019-05-16 12:28:22 -0700226
Paul Duffin250e6192019-06-07 10:44:37 +0100227 a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700228}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700229
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700230func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800231 cert := android.SrcIsModule(a.getCertString(ctx))
Colin Crossbd01e2a2018-10-04 15:21:03 -0700232 if cert != "" {
233 ctx.AddDependency(ctx.Module(), certificateTag, cert)
234 }
235
236 for _, cert := range a.appProperties.Additional_certificates {
237 cert = android.SrcIsModule(cert)
238 if cert != "" {
239 ctx.AddDependency(ctx.Module(), certificateTag, cert)
240 } else {
241 ctx.PropertyErrorf("additional_certificates",
242 `must be names of android_app_certificate modules in the form ":module"`)
243 }
244 }
Colin Cross30e076a2015-04-13 13:58:27 -0700245}
246
Jeongik Cha538c0d02019-07-11 15:54:27 +0900247func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
248 a.generateAndroidBuildActions(ctx)
249}
250
Colin Cross46c9b8b2017-06-22 16:51:17 -0700251func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900252 a.checkPlatformAPI(ctx)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900253 a.checkSdkVersion(ctx)
Colin Crossae5caf52018-05-22 11:11:52 -0700254 a.generateAndroidBuildActions(ctx)
255}
256
Sasha Smundak6ad77252019-05-01 13:16:22 -0700257// Returns true if the native libraries should be stored in the APK uncompressed and the
Colin Crosse4246ab2019-02-05 21:55:21 -0800258// extractNativeLibs application flag should be set to false in the manifest.
Sasha Smundak6ad77252019-05-01 13:16:22 -0700259func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
Jiyong Park6a927c42020-01-21 02:03:43 +0900260 minSdkVersion, err := a.minSdkVersion().effectiveVersion(ctx)
Colin Crosse4246ab2019-02-05 21:55:21 -0800261 if err != nil {
262 ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.minSdkVersion(), err)
263 }
264
Jiyong Park52cd06f2019-11-11 10:14:32 +0900265 return (minSdkVersion >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
266 !a.IsForPlatform()
Colin Crosse4246ab2019-02-05 21:55:21 -0800267}
268
Colin Cross43f08db2018-11-12 10:13:39 -0800269// Returns whether this module should have the dex file stored uncompressed in the APK.
270func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
Colin Cross46abdad2019-02-07 13:07:08 -0800271 if Bool(a.appProperties.Use_embedded_dex) {
272 return true
273 }
274
Colin Cross53a87f52019-06-25 13:35:30 -0700275 // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
276 // be preinstalled as prebuilts).
Jiyong Parkf7487312019-10-17 12:54:30 +0900277 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000278 return true
279 }
280
Colin Cross53a87f52019-06-25 13:35:30 -0700281 if ctx.Config().UnbundledBuild() {
282 return false
283 }
284
Jaewoong Jungacf18d72019-05-02 14:55:29 -0700285 return shouldUncompressDex(ctx, &a.dexpreopter)
Colin Cross5a0dcd52018-10-05 14:20:06 -0700286}
287
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700288func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
289 return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
Jiyong Park52cd06f2019-11-11 10:14:32 +0900290 !a.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700291}
292
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900293func (a *AndroidApp) OverriddenManifestPackageName() string {
294 return a.overriddenManifestPackageName
295}
296
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800297func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
David Brazdild25060a2019-02-18 18:24:16 +0000298 a.aapt.usesNonSdkApis = Bool(a.Module.deviceProperties.Platform_apis)
299
Jaewoong Jungc27ab662019-05-30 15:51:14 -0700300 // Ask manifest_fixer to add or update the application element indicating this app has no code.
301 a.aapt.hasNoCode = !a.hasCode(ctx)
302
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800303 aaptLinkFlags := []string{}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800304
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800305 // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800306 hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
Colin Crosse78dcd32018-04-19 15:25:19 -0700307 if !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800308 aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics())
Colin Crosse78dcd32018-04-19 15:25:19 -0700309 }
310
Dan Willemsen72be5902018-10-24 20:24:57 -0700311 if !Bool(a.aaptProperties.Aapt_include_all_resources) {
312 // Product AAPT config
313 for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800314 aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
Dan Willemsen72be5902018-10-24 20:24:57 -0700315 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700316
Dan Willemsen72be5902018-10-24 20:24:57 -0700317 // Product AAPT preferred config
318 if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800319 aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
Dan Willemsen72be5902018-10-24 20:24:57 -0700320 }
Colin Crosse78dcd32018-04-19 15:25:19 -0700321 }
322
Jiyong Park7f67f482019-01-05 12:57:48 +0900323 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
Jaewoong Jung6f373f62019-03-13 10:13:24 -0700324 if overridden || a.overridableAppProperties.Package_name != nil {
325 // The product override variable has a priority over the package_name property.
326 if !overridden {
327 manifestPackageName = *a.overridableAppProperties.Package_name
328 }
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800329 aaptLinkFlags = append(aaptLinkFlags, "--rename-manifest-package "+manifestPackageName)
Jiyong Parkcfaa1642020-02-28 16:51:07 +0900330 a.overriddenManifestPackageName = manifestPackageName
Jiyong Park7f67f482019-01-05 12:57:48 +0900331 }
332
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800333 aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
334
Colin Crosse560c4a2019-03-19 16:03:11 -0700335 a.aapt.splitNames = a.appProperties.Package_splits
Colin Cross50ddcc42019-05-16 12:28:22 -0700336 a.aapt.sdkLibraries = a.exportedSdkLibs
Baligh Uddin5b16dfb2020-02-11 17:27:19 -0800337 a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
Jaewoong Jungde4c02f2019-01-22 11:19:56 -0800338 a.aapt.buildActions(ctx, sdkContext(a), aaptLinkFlags...)
Colin Cross30e076a2015-04-13 13:58:27 -0700339
Colin Cross46c9b8b2017-06-22 16:51:17 -0700340 // apps manifests are handled by aapt, don't let Module see them
Dan Willemsen34cc69e2015-09-23 15:26:20 -0700341 a.properties.Manifest = nil
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800342}
Colin Cross30e076a2015-04-13 13:58:27 -0700343
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800344func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
Colin Cross89c31582018-04-30 15:55:11 -0700345 var staticLibProguardFlagFiles android.Paths
346 ctx.VisitDirectDeps(func(m android.Module) {
347 if lib, ok := m.(AndroidLibraryDependency); ok && ctx.OtherModuleDependencyTag(m) == staticLibTag {
348 staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, lib.ExportedProguardFlagFiles()...)
349 }
350 })
351
352 staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
353
354 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, staticLibProguardFlagFiles...)
355 a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, a.proguardOptionsFile)
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800356}
Colin Cross66dbc0b2017-12-28 12:23:20 -0800357
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800358func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) android.Path {
Colin Cross43f08db2018-11-12 10:13:39 -0800359
360 var installDir string
361 if ctx.ModuleName() == "framework-res" {
362 // framework-res.apk is installed as system/framework/framework-res.apk
363 installDir = "framework"
Jiyong Parkf7487312019-10-17 12:54:30 +0900364 } else if a.Privileged() {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800365 installDir = filepath.Join("priv-app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800366 } else {
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800367 installDir = filepath.Join("app", a.installApkName)
Colin Cross43f08db2018-11-12 10:13:39 -0800368 }
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800369 a.dexpreopter.installPath = android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000370 a.dexpreopter.uncompressedDex = a.shouldUncompressDex(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -0700371
372 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
373 a.dexpreopter.usesLibs = a.usesLibrary.usesLibraryProperties.Uses_libs
374 a.dexpreopter.optionalUsesLibs = a.usesLibrary.presentOptionalUsesLibs(ctx)
375 a.dexpreopter.libraryPaths = a.usesLibrary.usesLibraryPaths(ctx)
376 a.dexpreopter.manifestFile = a.mergedManifestFile
377
Nicolas Geoffrayfa6e9ec2019-02-12 13:12:16 +0000378 a.deviceProperties.UncompressDex = a.dexpreopter.uncompressedDex
Colin Cross5a0dcd52018-10-05 14:20:06 -0700379
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800380 if ctx.ModuleName() != "framework-res" {
381 a.Module.compile(ctx, a.aaptSrcJar)
382 }
Colin Cross30e076a2015-04-13 13:58:27 -0700383
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800384 return a.maybeStrippedDexJarFile
385}
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800386
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800387func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, ctx android.ModuleContext) android.WritablePath {
Colin Crossa4f08812018-10-02 22:03:40 -0700388 var jniJarFile android.WritablePath
Colin Crossa4f08812018-10-02 22:03:40 -0700389 if len(jniLibs) > 0 {
Jaewoong Jungbc625cd2019-05-06 15:48:44 -0700390 if a.shouldEmbedJnis(ctx) {
Colin Crossa4f08812018-10-02 22:03:40 -0700391 jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
Sasha Smundak6ad77252019-05-01 13:16:22 -0700392 TransformJniLibsToJar(ctx, jniJarFile, jniLibs, a.useEmbeddedNativeLibs(ctx))
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700393 for _, jni := range jniLibs {
394 if jni.coverageFile.Valid() {
395 a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
396 }
397 }
Colin Crossa4f08812018-10-02 22:03:40 -0700398 } else {
399 a.installJniLibs = jniLibs
400 }
401 }
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800402 return jniJarFile
403}
Colin Crossa4f08812018-10-02 22:03:40 -0700404
Jaewoong Jung0949f312019-09-11 10:25:18 -0700405func (a *AndroidApp) noticeBuildActions(ctx android.ModuleContext) {
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700406 // Collect NOTICE files from all dependencies.
407 seenModules := make(map[android.Module]bool)
408 noticePathSet := make(map[android.Path]bool)
409
410 ctx.WalkDeps(func(child android.Module, parent android.Module) bool {
411 // Have we already seen this?
412 if _, ok := seenModules[child]; ok {
413 return false
414 }
415 seenModules[child] = true
416
417 // Skip host modules.
418 if child.Target().Os.Class == android.Host || child.Target().Os.Class == android.HostCross {
419 return false
420 }
421
Bob Badoura75b0572020-02-18 20:21:55 -0800422 paths := child.(android.Module).NoticeFiles()
423 if len(paths) > 0 {
424 for _, path := range paths {
425 noticePathSet[path] = true
426 }
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700427 }
428 return true
429 })
430
431 // If the app has one, add it too.
Bob Badoura75b0572020-02-18 20:21:55 -0800432 if len(a.NoticeFiles()) > 0 {
433 for _, path := range a.NoticeFiles() {
434 noticePathSet[path] = true
435 }
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700436 }
437
438 if len(noticePathSet) == 0 {
Jaewoong Jung98772792019-07-01 17:15:13 -0700439 return
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700440 }
441 var noticePaths []android.Path
442 for path := range noticePathSet {
443 noticePaths = append(noticePaths, path)
444 }
445 sort.Slice(noticePaths, func(i, j int) bool {
446 return noticePaths[i].String() < noticePaths[j].String()
447 })
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700448
Jaewoong Jung0949f312019-09-11 10:25:18 -0700449 a.noticeOutputs = android.BuildNoticeOutput(ctx, a.installDir, a.installApkName+".apk", noticePaths)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700450}
451
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700452// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
453// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
454func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate, ctx android.ModuleContext) []Certificate {
455 if android.SrcIsModule(certPropValue) == "" {
456 var mainCert Certificate
457 if certPropValue != "" {
458 defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
459 mainCert = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800460 Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
461 Key: defaultDir.Join(ctx, certPropValue+".pk8"),
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700462 }
463 } else {
464 pem, key := ctx.Config().DefaultAppCertificate(ctx)
Colin Cross503c1d02020-01-28 14:00:53 -0800465 mainCert = Certificate{
466 Pem: pem,
467 Key: key,
468 }
Colin Crossbd01e2a2018-10-04 15:21:03 -0700469 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700470 certificates = append([]Certificate{mainCert}, certificates...)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700471 }
472
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700473 if !m.Platform() {
474 certPath := certificates[0].Pem.String()
Jeongik Chac9464142019-01-07 12:07:27 +0900475 systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
476 if strings.HasPrefix(certPath, systemCertPath) {
477 enforceSystemCert := ctx.Config().EnforceSystemCertificate()
478 whitelist := ctx.Config().EnforceSystemCertificateWhitelist()
479
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700480 if enforceSystemCert && !inList(m.Name(), whitelist) {
Jeongik Chac9464142019-01-07 12:07:27 +0900481 ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
482 }
483 }
484 }
485
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700486 return certificates
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800487}
488
489func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross50ddcc42019-05-16 12:28:22 -0700490 var apkDeps android.Paths
491
Jeongik Cha538c0d02019-07-11 15:54:27 +0900492 a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
493 a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
494
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800495 // Check if the install APK name needs to be overridden.
Jaewoong Jung525443a2019-02-28 15:35:54 -0800496 a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(a.Name())
Jaewoong Jung9d22a912019-01-23 16:27:47 -0800497
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700498 if ctx.ModuleName() == "framework-res" {
499 // framework-res.apk is installed as system/framework/framework-res.apk
Jaewoong Jung0949f312019-09-11 10:25:18 -0700500 a.installDir = android.PathForModuleInstall(ctx, "framework")
Jiyong Parkf7487312019-10-17 12:54:30 +0900501 } else if a.Privileged() {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700502 a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
503 } else if ctx.InstallInTestcases() {
Jaewoong Jung326a9412019-11-21 10:41:00 -0800504 a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700505 } else {
Jaewoong Jung0949f312019-09-11 10:25:18 -0700506 a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700507 }
Jaewoong Jung7dd4ae22019-09-27 17:13:15 -0700508 a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700509
Jaewoong Jung0949f312019-09-11 10:25:18 -0700510 a.noticeBuildActions(ctx)
Jaewoong Jung98772792019-07-01 17:15:13 -0700511 if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
512 a.aapt.noticeFile = a.noticeOutputs.HtmlGzOutput
513 }
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700514
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800515 // Process all building blocks, from AAPT to certificates.
516 a.aaptBuildActions(ctx)
517
Colin Cross50ddcc42019-05-16 12:28:22 -0700518 if a.usesLibrary.enforceUsesLibraries() {
519 manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile)
520 apkDeps = append(apkDeps, manifestCheckFile)
521 }
522
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800523 a.proguardBuildActions(ctx)
524
525 dexJarFile := a.dexBuildActions(ctx)
526
Colin Cross094cde42020-02-15 10:38:00 -0800527 jniLibs, certificateDeps := collectAppDeps(ctx, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800528 jniJarFile := a.jniBuildActions(jniLibs, ctx)
529
530 if ctx.Failed() {
531 return
532 }
533
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700534 certificates := processMainCert(a.ModuleBase, a.getCertString(ctx), certificateDeps, ctx)
535 a.certificate = certificates[0]
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800536
537 // Build a final signed app package.
Jaewoong Jung5a498812019-11-07 14:14:38 -0800538 packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700539 v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
540 var v4SignatureFile android.WritablePath = nil
541 if v4SigningRequested {
542 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
543 }
544 CreateAndSignAppPackage(ctx, packageFile, a.exportPackage, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile)
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800545 a.outputFile = packageFile
Songchun Fan17d69e32020-03-24 20:32:24 -0700546 if v4SigningRequested {
547 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
548 }
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800549
Colin Crosse560c4a2019-03-19 16:03:11 -0700550 for _, split := range a.aapt.splits {
551 // Sign the split APKs
Jaewoong Jung5a498812019-11-07 14:14:38 -0800552 packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -0700553 if v4SigningRequested {
554 v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
555 }
556 CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile)
Colin Crosse560c4a2019-03-19 16:03:11 -0700557 a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
Songchun Fan17d69e32020-03-24 20:32:24 -0700558 if v4SigningRequested {
559 a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
560 }
Colin Crosse560c4a2019-03-19 16:03:11 -0700561 }
562
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800563 // Build an app bundle.
Colin Crossf6237212018-10-29 23:14:58 -0700564 bundleFile := android.PathForModuleOut(ctx, "base.zip")
565 BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
566 a.bundleFile = bundleFile
567
Jaewoong Jung590b1ae2019-01-22 16:40:58 -0800568 // Install the app package.
Jiyong Park8ba50f92019-11-13 15:01:01 +0900569 if (Bool(a.Module.properties.Installable) || ctx.Host()) && a.IsForPlatform() {
570 ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile)
571 for _, extra := range a.extraOutputFiles {
572 ctx.InstallFile(a.installDir, extra.Base(), extra)
573 }
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800574 }
Colin Cross30e076a2015-04-13 13:58:27 -0700575}
576
Colin Cross094cde42020-02-15 10:38:00 -0800577func collectAppDeps(ctx android.ModuleContext, shouldCollectRecursiveNativeDeps bool,
578 checkNativeSdkVersion bool) ([]jniLib, []Certificate) {
Colin Crossa4f08812018-10-02 22:03:40 -0700579 var jniLibs []jniLib
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900580 var certificates []Certificate
Peter Collingbournead84f972019-12-17 16:46:18 -0800581 seenModulePaths := make(map[string]bool)
Colin Crossa4f08812018-10-02 22:03:40 -0700582
Peter Collingbournead84f972019-12-17 16:46:18 -0800583 ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
Colin Crossa4f08812018-10-02 22:03:40 -0700584 otherName := ctx.OtherModuleName(module)
585 tag := ctx.OtherModuleDependencyTag(module)
586
Peter Collingbournead84f972019-12-17 16:46:18 -0800587 if IsJniDepTag(tag) || tag == cc.SharedDepTag {
Colin Crossa4f08812018-10-02 22:03:40 -0700588 if dep, ok := module.(*cc.Module); ok {
Peter Collingbournead84f972019-12-17 16:46:18 -0800589 if dep.IsNdk() || dep.IsStubs() {
590 return false
591 }
592
Colin Crossa4f08812018-10-02 22:03:40 -0700593 lib := dep.OutputFile()
Peter Collingbournead84f972019-12-17 16:46:18 -0800594 path := lib.Path()
595 if seenModulePaths[path.String()] {
596 return false
597 }
598 seenModulePaths[path.String()] = true
599
Colin Cross094cde42020-02-15 10:38:00 -0800600 if checkNativeSdkVersion {
601 if app, ok := ctx.Module().(interface{ sdkVersion() sdkSpec }); ok {
602 if app.sdkVersion().specified() &&
603 app.sdkVersion().kind != sdkCorePlatform &&
604 dep.SdkVersion() == "" {
605 ctx.PropertyErrorf("jni_libs",
606 "JNI dependency %q uses platform APIs, but this module does not",
607 otherName)
608 }
609 }
610 }
611
Colin Crossa4f08812018-10-02 22:03:40 -0700612 if lib.Valid() {
613 jniLibs = append(jniLibs, jniLib{
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700614 name: ctx.OtherModuleName(module),
615 path: path,
616 target: module.Target(),
617 coverageFile: dep.CoverageOutputFile(),
Colin Crossa4f08812018-10-02 22:03:40 -0700618 })
619 } else {
620 ctx.ModuleErrorf("dependency %q missing output file", otherName)
621 }
622 } else {
623 ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
Colin Crossa4f08812018-10-02 22:03:40 -0700624 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800625
626 return shouldCollectRecursiveNativeDeps
627 }
628
629 if tag == certificateTag {
Colin Crossbd01e2a2018-10-04 15:21:03 -0700630 if dep, ok := module.(*AndroidAppCertificate); ok {
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900631 certificates = append(certificates, dep.Certificate)
Colin Crossbd01e2a2018-10-04 15:21:03 -0700632 } else {
633 ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
634 }
Colin Crossa4f08812018-10-02 22:03:40 -0700635 }
Peter Collingbournead84f972019-12-17 16:46:18 -0800636
637 return false
Colin Crossa4f08812018-10-02 22:03:40 -0700638 })
639
Colin Crossbd01e2a2018-10-04 15:21:03 -0700640 return jniLibs, certificates
Colin Crossa4f08812018-10-02 22:03:40 -0700641}
642
Colin Cross0ea8ba82019-06-06 14:33:29 -0700643func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800644 certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
645 if overridden {
Jaewoong Jungacb6db32019-02-28 16:22:30 +0000646 return ":" + certificate
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800647 }
Jaewoong Jung525443a2019-02-28 15:35:54 -0800648 return String(a.overridableAppProperties.Certificate)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800649}
650
Jiyong Park0f80c182020-01-31 02:49:53 +0900651func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
652 if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
653 return true
654 }
655 return a.Library.DepIsInSameApex(ctx, dep)
656}
657
Jiyong Parkb7c639e2019-08-19 14:56:02 +0900658// For OutputFileProducer interface
659func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
660 switch tag {
661 case ".aapt.srcjar":
662 return []android.Path{a.aaptSrcJar}, nil
663 }
664 return a.Library.OutputFiles(tag)
665}
666
Jiyong Parkf7487312019-10-17 12:54:30 +0900667func (a *AndroidApp) Privileged() bool {
668 return Bool(a.appProperties.Privileged)
669}
670
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700671func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool {
672 return ctx.Device() && (ctx.DeviceConfig().NativeCoverageEnabled() || ctx.DeviceConfig().ClangCoverageEnabled())
673}
674
675func (a *AndroidApp) PreventInstall() {
676 a.appProperties.PreventInstall = true
677}
678
679func (a *AndroidApp) HideFromMake() {
680 a.appProperties.HideFromMake = true
681}
682
683func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
684 a.appProperties.IsCoverageVariant = coverage
685}
686
687var _ cc.Coverage = (*AndroidApp)(nil)
688
Colin Cross1b16b0e2019-02-12 14:41:32 -0800689// android_app compiles sources and Android resources into an Android application package `.apk` file.
Colin Cross36242852017-06-23 15:06:31 -0700690func AndroidAppFactory() android.Module {
Colin Cross30e076a2015-04-13 13:58:27 -0700691 module := &AndroidApp{}
692
Sasha Smundak2057f822019-04-16 17:16:58 -0700693 module.Module.deviceProperties.Optimize.EnabledByDefault = true
Colin Cross66dbc0b2017-12-28 12:23:20 -0800694 module.Module.deviceProperties.Optimize.Shrink = proptools.BoolPtr(true)
695
Colin Crossae5caf52018-05-22 11:11:52 -0700696 module.Module.properties.Instrument = true
Colin Cross9ae1b922018-06-26 17:59:05 -0700697 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crossae5caf52018-05-22 11:11:52 -0700698
Colin Cross36242852017-06-23 15:06:31 -0700699 module.AddProperties(
Colin Cross540eff82017-06-22 17:01:52 -0700700 &module.Module.properties,
701 &module.Module.deviceProperties,
Colin Cross43f08db2018-11-12 10:13:39 -0800702 &module.Module.dexpreoptProperties,
Colin Crossa97c5d32018-03-28 14:58:31 -0700703 &module.Module.protoProperties,
704 &module.aaptProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -0800705 &module.appProperties,
Colin Cross50ddcc42019-05-16 12:28:22 -0700706 &module.overridableAppProperties,
707 &module.usesLibrary.usesLibraryProperties)
Colin Cross36242852017-06-23 15:06:31 -0700708
Colin Crossa9d8bee2018-10-02 13:59:46 -0700709 module.Prefer32(func(ctx android.BaseModuleContext, base *android.ModuleBase, class android.OsClass) bool {
710 return class == android.Device && ctx.Config().DevicePrefer32BitApps()
711 })
712
Colin Crossa4f08812018-10-02 22:03:40 -0700713 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
714 android.InitDefaultableModule(module)
Jaewoong Jung525443a2019-02-28 15:35:54 -0800715 android.InitOverridableModule(module, &module.appProperties.Overrides)
Jiyong Park52cd06f2019-11-11 10:14:32 +0900716 android.InitApexModule(module)
Colin Crossa4f08812018-10-02 22:03:40 -0700717
Colin Cross36242852017-06-23 15:06:31 -0700718 return module
Colin Cross30e076a2015-04-13 13:58:27 -0700719}
Colin Crossae5caf52018-05-22 11:11:52 -0700720
721type appTestProperties struct {
722 Instrumentation_for *string
Jaewoong Jung26dedd32019-06-06 08:45:58 -0700723
724 // if specified, the instrumentation target package name in the manifest is overwritten by it.
725 Instrumentation_target_package *string
Colin Crossae5caf52018-05-22 11:11:52 -0700726}
727
728type AndroidTest struct {
729 AndroidApp
730
731 appTestProperties appTestProperties
732
733 testProperties testProperties
Colin Cross303e21f2018-08-07 16:49:25 -0700734
735 testConfig android.Path
Colin Crossd96ca352018-08-10 16:06:24 -0700736 data android.Paths
Colin Crossae5caf52018-05-22 11:11:52 -0700737}
738
Jaewoong Jung0949f312019-09-11 10:25:18 -0700739func (a *AndroidTest) InstallInTestcases() bool {
740 return true
741}
742
Colin Crossae5caf52018-05-22 11:11:52 -0700743func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Jaewoong Jung26dedd32019-06-06 08:45:58 -0700744 if a.appTestProperties.Instrumentation_target_package != nil {
745 a.additionalAaptFlags = append(a.additionalAaptFlags,
746 "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
747 } else if a.appTestProperties.Instrumentation_for != nil {
748 // Check if the instrumentation target package is overridden.
Jaewoong Jung4102e5d2019-02-27 16:26:28 -0800749 manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
750 if overridden {
751 a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
752 }
753 }
Colin Crossae5caf52018-05-22 11:11:52 -0700754 a.generateAndroidBuildActions(ctx)
Colin Cross303e21f2018-08-07 16:49:25 -0700755
Jaewoong Jung39982342020-01-14 10:27:18 -0800756 testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
Dan Shi6ffaaa82019-09-26 11:41:36 -0700757 a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config)
Jaewoong Jung39982342020-01-14 10:27:18 -0800758 a.testConfig = a.FixTestConfig(ctx, testConfig)
Colin Cross8a497952019-03-05 22:25:09 -0800759 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
Colin Cross303e21f2018-08-07 16:49:25 -0700760}
761
Jaewoong Jung39982342020-01-14 10:27:18 -0800762func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
763 if testConfig == nil {
764 return nil
765 }
766
767 fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
768 rule := android.NewRuleBuilder()
769 command := rule.Command().BuiltTool(ctx, "test_config_fixer").Input(testConfig).Output(fixedConfig)
770 fixNeeded := false
771
772 if ctx.ModuleName() != a.installApkName {
773 fixNeeded = true
774 command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
775 }
776
777 if a.overridableAppProperties.Package_name != nil {
778 fixNeeded = true
779 command.FlagWithInput("--manifest ", a.manifestPath).
780 FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
781 }
782
783 if fixNeeded {
784 rule.Build(pctx, ctx, "fix_test_config", "fix test config")
785 return fixedConfig
786 }
787 return testConfig
788}
789
Colin Cross303e21f2018-08-07 16:49:25 -0700790func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
Colin Cross303e21f2018-08-07 16:49:25 -0700791 a.AndroidApp.DepsMutator(ctx)
Jaewoong Jung26dedd32019-06-06 08:45:58 -0700792}
793
794func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
795 a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
Colin Cross4b964c02018-10-15 16:18:06 -0700796 if a.appTestProperties.Instrumentation_for != nil {
797 // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
798 // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
799 // use instrumentationForTag instead of libTag.
800 ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
801 }
Colin Crossae5caf52018-05-22 11:11:52 -0700802}
803
Colin Cross1b16b0e2019-02-12 14:41:32 -0800804// android_test compiles test sources and Android resources into an Android application package `.apk` file and
805// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
Colin Crossae5caf52018-05-22 11:11:52 -0700806func AndroidTestFactory() android.Module {
807 module := &AndroidTest{}
808
Sasha Smundak2057f822019-04-16 17:16:58 -0700809 module.Module.deviceProperties.Optimize.EnabledByDefault = true
Colin Cross5067db92018-09-17 16:46:35 -0700810
811 module.Module.properties.Instrument = true
Colin Cross9ae1b922018-06-26 17:59:05 -0700812 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -0800813 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -0700814 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -0800815 module.Module.dexpreopter.isTest = true
Colin Crossae5caf52018-05-22 11:11:52 -0700816
817 module.AddProperties(
818 &module.Module.properties,
819 &module.Module.deviceProperties,
Colin Cross43f08db2018-11-12 10:13:39 -0800820 &module.Module.dexpreoptProperties,
Colin Crossae5caf52018-05-22 11:11:52 -0700821 &module.Module.protoProperties,
822 &module.aaptProperties,
823 &module.appProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -0700824 &module.appTestProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -0800825 &module.overridableAppProperties,
Colin Cross50ddcc42019-05-16 12:28:22 -0700826 &module.usesLibrary.usesLibraryProperties,
Dan Willemsenf5531d22018-07-16 17:21:19 -0700827 &module.testProperties)
Colin Crossae5caf52018-05-22 11:11:52 -0700828
Colin Crossa4f08812018-10-02 22:03:40 -0700829 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
830 android.InitDefaultableModule(module)
Jaewoong Jung26dedd32019-06-06 08:45:58 -0700831 android.InitOverridableModule(module, &module.appProperties.Overrides)
Colin Crossae5caf52018-05-22 11:11:52 -0700832 return module
833}
Colin Crossbd01e2a2018-10-04 15:21:03 -0700834
Colin Cross252fc6f2018-10-04 15:22:03 -0700835type appTestHelperAppProperties struct {
836 // list of compatibility suites (for example "cts", "vts") that the module should be
837 // installed into.
838 Test_suites []string `android:"arch_variant"`
Dan Shi6ffaaa82019-09-26 11:41:36 -0700839
840 // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
841 // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
842 // explicitly.
843 Auto_gen_config *bool
Colin Cross252fc6f2018-10-04 15:22:03 -0700844}
845
846type AndroidTestHelperApp struct {
847 AndroidApp
848
849 appTestHelperAppProperties appTestHelperAppProperties
850}
851
Jaewoong Jung326a9412019-11-21 10:41:00 -0800852func (a *AndroidTestHelperApp) InstallInTestcases() bool {
853 return true
854}
855
Colin Cross1b16b0e2019-02-12 14:41:32 -0800856// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
857// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
858// test.
Colin Cross252fc6f2018-10-04 15:22:03 -0700859func AndroidTestHelperAppFactory() android.Module {
860 module := &AndroidTestHelperApp{}
861
Sasha Smundak2057f822019-04-16 17:16:58 -0700862 module.Module.deviceProperties.Optimize.EnabledByDefault = true
Colin Cross252fc6f2018-10-04 15:22:03 -0700863
864 module.Module.properties.Installable = proptools.BoolPtr(true)
Colin Crosse4246ab2019-02-05 21:55:21 -0800865 module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
Colin Cross47fa9d32019-03-26 10:51:39 -0700866 module.appProperties.AlwaysPackageNativeLibs = true
Colin Cross43f08db2018-11-12 10:13:39 -0800867 module.Module.dexpreopter.isTest = true
Colin Cross252fc6f2018-10-04 15:22:03 -0700868
869 module.AddProperties(
870 &module.Module.properties,
871 &module.Module.deviceProperties,
Colin Cross43f08db2018-11-12 10:13:39 -0800872 &module.Module.dexpreoptProperties,
Colin Cross252fc6f2018-10-04 15:22:03 -0700873 &module.Module.protoProperties,
874 &module.aaptProperties,
875 &module.appProperties,
Jaewoong Jung525443a2019-02-28 15:35:54 -0800876 &module.appTestHelperAppProperties,
Colin Cross50ddcc42019-05-16 12:28:22 -0700877 &module.overridableAppProperties,
878 &module.usesLibrary.usesLibraryProperties)
Colin Cross252fc6f2018-10-04 15:22:03 -0700879
880 android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
881 android.InitDefaultableModule(module)
Anton Hansson3d2b6b42020-01-10 15:06:01 +0000882 android.InitApexModule(module)
Colin Cross252fc6f2018-10-04 15:22:03 -0700883 return module
884}
885
Colin Crossbd01e2a2018-10-04 15:21:03 -0700886type AndroidAppCertificate struct {
887 android.ModuleBase
888 properties AndroidAppCertificateProperties
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900889 Certificate Certificate
Colin Crossbd01e2a2018-10-04 15:21:03 -0700890}
891
892type AndroidAppCertificateProperties struct {
893 // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
894 Certificate *string
895}
896
Colin Cross1b16b0e2019-02-12 14:41:32 -0800897// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
898// the signing key.
Colin Crossbd01e2a2018-10-04 15:21:03 -0700899func AndroidAppCertificateFactory() android.Module {
900 module := &AndroidAppCertificate{}
901 module.AddProperties(&module.properties)
902 android.InitAndroidModule(module)
903 return module
904}
905
Colin Crossbd01e2a2018-10-04 15:21:03 -0700906func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
907 cert := String(c.properties.Certificate)
Jiyong Parkc00cbd92018-10-30 21:20:05 +0900908 c.Certificate = Certificate{
Colin Cross503c1d02020-01-28 14:00:53 -0800909 Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
910 Key: android.PathForModuleSrc(ctx, cert+".pk8"),
Colin Crossbd01e2a2018-10-04 15:21:03 -0700911 }
912}
Jaewoong Jung525443a2019-02-28 15:35:54 -0800913
914type OverrideAndroidApp struct {
915 android.ModuleBase
916 android.OverrideModuleBase
917}
918
919func (i *OverrideAndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
920 // All the overrides happen in the base module.
921 // TODO(jungjw): Check the base module type.
922}
923
924// override_android_app is used to create an android_app module based on another android_app by overriding
925// some of its properties.
926func OverrideAndroidAppModuleFactory() android.Module {
927 m := &OverrideAndroidApp{}
928 m.AddProperties(&overridableAppProperties{})
929
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700930 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
Jaewoong Jung525443a2019-02-28 15:35:54 -0800931 android.InitOverrideModule(m)
932 return m
933}
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700934
Jaewoong Jung26dedd32019-06-06 08:45:58 -0700935type OverrideAndroidTest struct {
936 android.ModuleBase
937 android.OverrideModuleBase
938}
939
940func (i *OverrideAndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
941 // All the overrides happen in the base module.
942 // TODO(jungjw): Check the base module type.
943}
944
945// override_android_test is used to create an android_app module based on another android_test by overriding
946// some of its properties.
947func OverrideAndroidTestModuleFactory() android.Module {
948 m := &OverrideAndroidTest{}
949 m.AddProperties(&overridableAppProperties{})
950 m.AddProperties(&appTestProperties{})
951
952 android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
953 android.InitOverrideModule(m)
954 return m
955}
956
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700957type AndroidAppImport struct {
958 android.ModuleBase
959 android.DefaultableModuleBase
960 prebuilt android.Prebuilt
961
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -0700962 properties AndroidAppImportProperties
963 dpiVariants interface{}
964 archVariants interface{}
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700965
966 outputFile android.Path
Colin Cross503c1d02020-01-28 14:00:53 -0800967 certificate Certificate
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700968
969 dexpreopter
Colin Cross50ddcc42019-05-16 12:28:22 -0700970
971 usesLibrary usesLibrary
Jaewoong Jung8aae22e2019-07-17 10:21:49 -0700972
Colin Cross70dda7e2019-10-01 22:05:35 -0700973 installPath android.InstallPath
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700974}
975
976type AndroidAppImportProperties struct {
977 // A prebuilt apk to import
Jaewoong Jung3e18b192019-06-11 12:25:34 -0700978 Apk *string
Jaewoong Junga5e5abc2019-04-26 14:31:50 -0700979
Jaewoong Jung961d4fd2019-08-22 14:25:58 -0700980 // The name of a certificate in the default certificate directory or an android_app_certificate
981 // module name in the form ":module". Should be empty if presigned or default_dev_cert is set.
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700982 Certificate *string
983
984 // Set this flag to true if the prebuilt apk is already signed. The certificate property must not
985 // be set for presigned modules.
986 Presigned *bool
987
Jaewoong Jung961d4fd2019-08-22 14:25:58 -0700988 // Sign with the default system dev certificate. Must be used judiciously. Most imported apps
989 // need to either specify a specific certificate or be presigned.
990 Default_dev_cert *bool
991
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700992 // Specifies that this app should be installed to the priv-app directory,
993 // where the system will grant it additional privileges not available to
994 // normal apps.
995 Privileged *bool
996
997 // Names of modules to be overridden. Listed modules can only be other binaries
998 // (in Make or Soong).
999 // This does not completely prevent installation of the overridden binaries, but if both
1000 // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
1001 // from PRODUCT_PACKAGES.
1002 Overrides []string
Jaewoong Jung8aae22e2019-07-17 10:21:49 -07001003
1004 // Optional name for the installed app. If unspecified, it is derived from the module name.
1005 Filename *string
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001006}
1007
Martin Stjernholm6d415272020-01-31 17:10:36 +00001008func (a *AndroidAppImport) IsInstallable() bool {
1009 return true
1010}
1011
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001012// Updates properties with variant-specific values.
1013func (a *AndroidAppImport) processVariants(ctx android.LoadHookContext) {
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001014 config := ctx.Config()
1015
1016 dpiProps := reflect.ValueOf(a.dpiVariants).Elem().FieldByName("Dpi_variants")
1017 // Try DPI variant matches in the reverse-priority order so that the highest priority match
1018 // overwrites everything else.
1019 // TODO(jungjw): Can we optimize this by making it priority order?
1020 for i := len(config.ProductAAPTPrebuiltDPI()) - 1; i >= 0; i-- {
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001021 MergePropertiesFromVariant(ctx, &a.properties, dpiProps, config.ProductAAPTPrebuiltDPI()[i])
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001022 }
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001023 if config.ProductAAPTPreferredConfig() != "" {
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001024 MergePropertiesFromVariant(ctx, &a.properties, dpiProps, config.ProductAAPTPreferredConfig())
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001025 }
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001026
1027 archProps := reflect.ValueOf(a.archVariants).Elem().FieldByName("Arch")
1028 archType := ctx.Config().Targets[android.Android][0].Arch.ArchType
1029 MergePropertiesFromVariant(ctx, &a.properties, archProps, archType.Name)
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001030}
1031
Colin Cross1184b642019-12-30 18:43:07 -08001032func MergePropertiesFromVariant(ctx android.EarlyModuleContext,
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001033 dst interface{}, variantGroup reflect.Value, variant string) {
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001034 src := variantGroup.FieldByName(proptools.FieldNameForProperty(variant))
1035 if !src.IsValid() {
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001036 return
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001037 }
1038
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001039 err := proptools.ExtendMatchingProperties([]interface{}{dst}, src.Interface(), nil, proptools.OrderAppend)
1040 if err != nil {
1041 if propertyErr, ok := err.(*proptools.ExtendPropertyError); ok {
1042 ctx.PropertyErrorf(propertyErr.Property, "%s", propertyErr.Err.Error())
1043 } else {
1044 panic(err)
1045 }
1046 }
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001047}
1048
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001049func (a *AndroidAppImport) DepsMutator(ctx android.BottomUpMutatorContext) {
1050 cert := android.SrcIsModule(String(a.properties.Certificate))
1051 if cert != "" {
1052 ctx.AddDependency(ctx.Module(), certificateTag, cert)
1053 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001054
Paul Duffin250e6192019-06-07 10:44:37 +01001055 a.usesLibrary.deps(ctx, true)
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001056}
1057
1058func (a *AndroidAppImport) uncompressEmbeddedJniLibs(
1059 ctx android.ModuleContext, inputPath android.Path, outputPath android.OutputPath) {
Jaewoong Jung7c5bd832020-01-13 09:55:39 -08001060 // Test apps don't need their JNI libraries stored uncompressed. As a matter of fact, messing
1061 // with them may invalidate pre-existing signature data.
1062 if ctx.InstallInTestcases() && Bool(a.properties.Presigned) {
1063 ctx.Build(pctx, android.BuildParams{
1064 Rule: android.Cp,
1065 Output: outputPath,
1066 Input: inputPath,
1067 })
1068 return
1069 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001070 rule := android.NewRuleBuilder()
1071 rule.Command().
1072 Textf(`if (zipinfo %s 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then`, inputPath).
Colin Crossee94d6a2019-07-08 17:08:34 -07001073 BuiltTool(ctx, "zip2zip").
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001074 FlagWithInput("-i ", inputPath).
1075 FlagWithOutput("-o ", outputPath).
1076 FlagWithArg("-0 ", "'lib/**/*.so'").
1077 Textf(`; else cp -f %s %s; fi`, inputPath, outputPath)
1078 rule.Build(pctx, ctx, "uncompress-embedded-jni-libs", "Uncompress embedded JIN libs")
1079}
1080
Jaewoong Jungacf18d72019-05-02 14:55:29 -07001081// Returns whether this module should have the dex file stored uncompressed in the APK.
1082func (a *AndroidAppImport) shouldUncompressDex(ctx android.ModuleContext) bool {
1083 if ctx.Config().UnbundledBuild() {
1084 return false
1085 }
1086
1087 // Uncompress dex in APKs of privileged apps
Jiyong Parkf7487312019-10-17 12:54:30 +09001088 if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
Jaewoong Jungacf18d72019-05-02 14:55:29 -07001089 return true
1090 }
1091
1092 return shouldUncompressDex(ctx, &a.dexpreopter)
1093}
1094
Jaewoong Jungea1bdb02019-05-09 14:36:34 -07001095func (a *AndroidAppImport) uncompressDex(
1096 ctx android.ModuleContext, inputPath android.Path, outputPath android.OutputPath) {
1097 rule := android.NewRuleBuilder()
1098 rule.Command().
1099 Textf(`if (zipinfo %s '*.dex' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then`, inputPath).
Colin Crossee94d6a2019-07-08 17:08:34 -07001100 BuiltTool(ctx, "zip2zip").
Jaewoong Jungea1bdb02019-05-09 14:36:34 -07001101 FlagWithInput("-i ", inputPath).
1102 FlagWithOutput("-o ", outputPath).
1103 FlagWithArg("-0 ", "'classes*.dex'").
1104 Textf(`; else cp -f %s %s; fi`, inputPath, outputPath)
1105 rule.Build(pctx, ctx, "uncompress-dex", "Uncompress dex files")
1106}
1107
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001108func (a *AndroidAppImport) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Jaewoong Jungb28eb5f2019-08-27 15:01:50 -07001109 a.generateAndroidBuildActions(ctx)
1110}
1111
1112func (a *AndroidAppImport) generateAndroidBuildActions(ctx android.ModuleContext) {
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001113 numCertPropsSet := 0
1114 if String(a.properties.Certificate) != "" {
1115 numCertPropsSet++
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001116 }
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001117 if Bool(a.properties.Presigned) {
1118 numCertPropsSet++
1119 }
1120 if Bool(a.properties.Default_dev_cert) {
1121 numCertPropsSet++
1122 }
1123 if numCertPropsSet != 1 {
1124 ctx.ModuleErrorf("One and only one of certficate, presigned, and default_dev_cert properties must be set")
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001125 }
1126
Colin Cross094cde42020-02-15 10:38:00 -08001127 _, certificates := collectAppDeps(ctx, false, false)
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001128
1129 // TODO: LOCAL_EXTRACT_APK/LOCAL_EXTRACT_DPI_APK
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001130 // TODO: LOCAL_PACKAGE_SPLITS
1131
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001132 srcApk := a.prebuilt.SingleSourcePath(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001133
1134 if a.usesLibrary.enforceUsesLibraries() {
1135 srcApk = a.usesLibrary.verifyUsesLibrariesAPK(ctx, srcApk)
1136 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001137
1138 // TODO: Install or embed JNI libraries
1139
1140 // Uncompress JNI libraries in the apk
1141 jnisUncompressed := android.PathForModuleOut(ctx, "jnis-uncompressed", ctx.ModuleName()+".apk")
1142 a.uncompressEmbeddedJniLibs(ctx, srcApk, jnisUncompressed.OutputPath)
1143
Kyeongkab.Namc4997142019-11-22 11:38:16 +09001144 var installDir android.InstallPath
1145 if Bool(a.properties.Privileged) {
1146 installDir = android.PathForModuleInstall(ctx, "priv-app", a.BaseModuleName())
Jaewoong Jung7c5bd832020-01-13 09:55:39 -08001147 } else if ctx.InstallInTestcases() {
1148 installDir = android.PathForModuleInstall(ctx, a.BaseModuleName(), ctx.DeviceConfig().DeviceArch())
Kyeongkab.Namc4997142019-11-22 11:38:16 +09001149 } else {
1150 installDir = android.PathForModuleInstall(ctx, "app", a.BaseModuleName())
1151 }
1152
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001153 a.dexpreopter.installPath = installDir.Join(ctx, a.BaseModuleName()+".apk")
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001154 a.dexpreopter.isPresignedPrebuilt = Bool(a.properties.Presigned)
Jaewoong Jungacf18d72019-05-02 14:55:29 -07001155 a.dexpreopter.uncompressedDex = a.shouldUncompressDex(ctx)
Colin Cross50ddcc42019-05-16 12:28:22 -07001156
1157 a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
1158 a.dexpreopter.usesLibs = a.usesLibrary.usesLibraryProperties.Uses_libs
1159 a.dexpreopter.optionalUsesLibs = a.usesLibrary.presentOptionalUsesLibs(ctx)
1160 a.dexpreopter.libraryPaths = a.usesLibrary.usesLibraryPaths(ctx)
1161
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001162 dexOutput := a.dexpreopter.dexpreopt(ctx, jnisUncompressed)
Jaewoong Jungea1bdb02019-05-09 14:36:34 -07001163 if a.dexpreopter.uncompressedDex {
1164 dexUncompressed := android.PathForModuleOut(ctx, "dex-uncompressed", ctx.ModuleName()+".apk")
1165 a.uncompressDex(ctx, dexOutput, dexUncompressed.OutputPath)
1166 dexOutput = dexUncompressed
1167 }
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001168
1169 // Sign or align the package
1170 // TODO: Handle EXTERNAL
1171 if !Bool(a.properties.Presigned) {
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001172 // If the certificate property is empty at this point, default_dev_cert must be set to true.
1173 // Which makes processMainCert's behavior for the empty cert string WAI.
1174 certificates = processMainCert(a.ModuleBase, String(a.properties.Certificate), certificates, ctx)
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001175 if len(certificates) != 1 {
1176 ctx.ModuleErrorf("Unexpected number of certificates were extracted: %q", certificates)
1177 }
Colin Cross503c1d02020-01-28 14:00:53 -08001178 a.certificate = certificates[0]
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001179 signed := android.PathForModuleOut(ctx, "signed", ctx.ModuleName()+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -07001180 SignAppPackage(ctx, signed, dexOutput, certificates, nil)
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001181 a.outputFile = signed
1182 } else {
1183 alignedApk := android.PathForModuleOut(ctx, "zip-aligned", ctx.ModuleName()+".apk")
1184 TransformZipAlign(ctx, alignedApk, dexOutput)
1185 a.outputFile = alignedApk
Colin Cross503c1d02020-01-28 14:00:53 -08001186 a.certificate = presignedCertificate
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001187 }
1188
1189 // TODO: Optionally compress the output apk.
1190
Jaewoong Jung8aae22e2019-07-17 10:21:49 -07001191 a.installPath = ctx.InstallFile(installDir,
1192 proptools.StringDefault(a.properties.Filename, a.BaseModuleName()+".apk"), a.outputFile)
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001193
1194 // TODO: androidmk converter jni libs
1195}
1196
1197func (a *AndroidAppImport) Prebuilt() *android.Prebuilt {
1198 return &a.prebuilt
1199}
1200
1201func (a *AndroidAppImport) Name() string {
1202 return a.prebuilt.Name(a.ModuleBase.Name())
1203}
1204
Dario Frenicde2a032019-10-27 00:29:22 +01001205func (a *AndroidAppImport) OutputFile() android.Path {
1206 return a.outputFile
1207}
1208
Jiyong Park618922e2020-01-08 13:35:43 +09001209func (a *AndroidAppImport) JacocoReportClassesFile() android.Path {
1210 return nil
1211}
1212
Colin Cross503c1d02020-01-28 14:00:53 -08001213func (a *AndroidAppImport) Certificate() Certificate {
1214 return a.certificate
1215}
1216
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001217var dpiVariantGroupType reflect.Type
1218var archVariantGroupType reflect.Type
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001219
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001220func initAndroidAppImportVariantGroupTypes() {
1221 dpiVariantGroupType = createVariantGroupType(supportedDpis, "Dpi_variants")
1222
1223 archNames := make([]string, len(android.ArchTypeList()))
1224 for i, archType := range android.ArchTypeList() {
1225 archNames[i] = archType.Name
1226 }
1227 archVariantGroupType = createVariantGroupType(archNames, "Arch")
1228}
1229
1230// Populates all variant struct properties at creation time.
1231func (a *AndroidAppImport) populateAllVariantStructs() {
1232 a.dpiVariants = reflect.New(dpiVariantGroupType).Interface()
1233 a.AddProperties(a.dpiVariants)
1234
1235 a.archVariants = reflect.New(archVariantGroupType).Interface()
1236 a.AddProperties(a.archVariants)
1237}
1238
Jiyong Parkf7487312019-10-17 12:54:30 +09001239func (a *AndroidAppImport) Privileged() bool {
1240 return Bool(a.properties.Privileged)
1241}
1242
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001243func createVariantGroupType(variants []string, variantGroupName string) reflect.Type {
1244 props := reflect.TypeOf((*AndroidAppImportProperties)(nil))
1245
1246 variantFields := make([]reflect.StructField, len(variants))
1247 for i, variant := range variants {
1248 variantFields[i] = reflect.StructField{
1249 Name: proptools.FieldNameForProperty(variant),
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001250 Type: props,
1251 }
1252 }
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001253
1254 variantGroupStruct := reflect.StructOf(variantFields)
1255 return reflect.StructOf([]reflect.StructField{
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001256 {
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001257 Name: variantGroupName,
1258 Type: variantGroupStruct,
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001259 },
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001260 })
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001261}
1262
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001263// android_app_import imports a prebuilt apk with additional processing specified in the module.
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001264// DPI-specific apk source files can be specified using dpi_variants. Example:
1265//
1266// android_app_import {
1267// name: "example_import",
1268// apk: "prebuilts/example.apk",
1269// dpi_variants: {
1270// mdpi: {
1271// apk: "prebuilts/example_mdpi.apk",
1272// },
1273// xhdpi: {
1274// apk: "prebuilts/example_xhdpi.apk",
1275// },
1276// },
1277// certificate: "PRESIGNED",
1278// }
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001279func AndroidAppImportFactory() android.Module {
1280 module := &AndroidAppImport{}
1281 module.AddProperties(&module.properties)
1282 module.AddProperties(&module.dexpreoptProperties)
Colin Cross50ddcc42019-05-16 12:28:22 -07001283 module.AddProperties(&module.usesLibrary.usesLibraryProperties)
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001284 module.populateAllVariantStructs()
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001285 android.AddLoadHook(module, func(ctx android.LoadHookContext) {
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001286 module.processVariants(ctx)
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001287 })
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001288
1289 InitJavaModule(module, android.DeviceSupported)
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001290 android.InitSingleSourcePrebuiltModule(module, &module.properties, "Apk")
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001291
1292 return module
1293}
Colin Cross50ddcc42019-05-16 12:28:22 -07001294
Jaewoong Jungb28eb5f2019-08-27 15:01:50 -07001295type AndroidTestImport struct {
1296 AndroidAppImport
1297
1298 testProperties testProperties
1299
1300 data android.Paths
1301}
1302
1303func (a *AndroidTestImport) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1304 a.generateAndroidBuildActions(ctx)
1305
1306 a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
1307}
1308
Jaewoong Jung7c5bd832020-01-13 09:55:39 -08001309func (a *AndroidTestImport) InstallInTestcases() bool {
1310 return true
1311}
1312
Jaewoong Jungb28eb5f2019-08-27 15:01:50 -07001313// android_test_import imports a prebuilt test apk with additional processing specified in the
1314// module. DPI or arch variant configurations can be made as with android_app_import.
1315func AndroidTestImportFactory() android.Module {
1316 module := &AndroidTestImport{}
1317 module.AddProperties(&module.properties)
1318 module.AddProperties(&module.dexpreoptProperties)
1319 module.AddProperties(&module.usesLibrary.usesLibraryProperties)
1320 module.AddProperties(&module.testProperties)
1321 module.populateAllVariantStructs()
1322 android.AddLoadHook(module, func(ctx android.LoadHookContext) {
1323 module.processVariants(ctx)
1324 })
1325
1326 InitJavaModule(module, android.DeviceSupported)
1327 android.InitSingleSourcePrebuiltModule(module, &module.properties, "Apk")
1328
1329 return module
1330}
1331
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001332type RuntimeResourceOverlay struct {
1333 android.ModuleBase
1334 android.DefaultableModuleBase
1335 aapt
1336
1337 properties RuntimeResourceOverlayProperties
1338
Jaewoong Jung78ec5d82020-01-31 10:11:47 -08001339 certificate Certificate
1340
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001341 outputFile android.Path
1342 installDir android.InstallPath
1343}
1344
1345type RuntimeResourceOverlayProperties struct {
1346 // the name of a certificate in the default certificate directory or an android_app_certificate
1347 // module name in the form ":module".
1348 Certificate *string
1349
1350 // optional theme name. If specified, the overlay package will be applied
1351 // only when the ro.boot.vendor.overlay.theme system property is set to the same value.
1352 Theme *string
1353
1354 // if not blank, set to the version of the sdk to compile against.
1355 // Defaults to compiling against the current platform.
1356 Sdk_version *string
1357
1358 // if not blank, set the minimum version of the sdk that the compiled artifacts will run against.
1359 // Defaults to sdk_version if not set.
1360 Min_sdk_version *string
1361}
1362
1363func (r *RuntimeResourceOverlay) DepsMutator(ctx android.BottomUpMutatorContext) {
1364 sdkDep := decodeSdkDep(ctx, sdkContext(r))
1365 if sdkDep.hasFrameworkLibs() {
1366 r.aapt.deps(ctx, sdkDep)
1367 }
1368
1369 cert := android.SrcIsModule(String(r.properties.Certificate))
1370 if cert != "" {
1371 ctx.AddDependency(ctx.Module(), certificateTag, cert)
1372 }
1373}
1374
1375func (r *RuntimeResourceOverlay) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1376 // Compile and link resources
1377 r.aapt.hasNoCode = true
Jaewoong Jungf0f747c2020-01-24 10:30:02 -08001378 // Do not remove resources without default values nor dedupe resource configurations with the same value
1379 r.aapt.buildActions(ctx, r, "--no-resource-deduping", "--no-resource-removal")
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001380
1381 // Sign the built package
Colin Cross094cde42020-02-15 10:38:00 -08001382 _, certificates := collectAppDeps(ctx, false, false)
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001383 certificates = processMainCert(r.ModuleBase, String(r.properties.Certificate), certificates, ctx)
1384 signed := android.PathForModuleOut(ctx, "signed", r.Name()+".apk")
Songchun Fan17d69e32020-03-24 20:32:24 -07001385 SignAppPackage(ctx, signed, r.aapt.exportPackage, certificates, nil)
Jaewoong Jung78ec5d82020-01-31 10:11:47 -08001386 r.certificate = certificates[0]
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001387
1388 r.outputFile = signed
1389 r.installDir = android.PathForModuleInstall(ctx, "overlay", String(r.properties.Theme))
1390 ctx.InstallFile(r.installDir, r.outputFile.Base(), r.outputFile)
1391}
1392
Jiyong Park6a927c42020-01-21 02:03:43 +09001393func (r *RuntimeResourceOverlay) sdkVersion() sdkSpec {
1394 return sdkSpecFrom(String(r.properties.Sdk_version))
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001395}
1396
1397func (r *RuntimeResourceOverlay) systemModules() string {
1398 return ""
1399}
1400
Jiyong Park6a927c42020-01-21 02:03:43 +09001401func (r *RuntimeResourceOverlay) minSdkVersion() sdkSpec {
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001402 if r.properties.Min_sdk_version != nil {
Jiyong Park6a927c42020-01-21 02:03:43 +09001403 return sdkSpecFrom(*r.properties.Min_sdk_version)
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001404 }
1405 return r.sdkVersion()
1406}
1407
Jiyong Park6a927c42020-01-21 02:03:43 +09001408func (r *RuntimeResourceOverlay) targetSdkVersion() sdkSpec {
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08001409 return r.sdkVersion()
1410}
1411
1412// runtime_resource_overlay generates a resource-only apk file that can overlay application and
1413// system resources at run time.
1414func RuntimeResourceOverlayFactory() android.Module {
1415 module := &RuntimeResourceOverlay{}
1416 module.AddProperties(
1417 &module.properties,
1418 &module.aaptProperties)
1419
1420 InitJavaModule(module, android.DeviceSupported)
1421
1422 return module
1423}
1424
Colin Cross50ddcc42019-05-16 12:28:22 -07001425type UsesLibraryProperties struct {
1426 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
1427 Uses_libs []string
1428
1429 // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
1430 // required=false.
1431 Optional_uses_libs []string
1432
1433 // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
1434 // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
1435 Enforce_uses_libs *bool
1436}
1437
1438// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
1439// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
1440// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
1441// with knowledge of their shared libraries.
1442type usesLibrary struct {
1443 usesLibraryProperties UsesLibraryProperties
1444}
1445
Paul Duffin250e6192019-06-07 10:44:37 +01001446func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, hasFrameworkLibs bool) {
Colin Cross3245b2c2019-06-07 13:18:09 -07001447 if !ctx.Config().UnbundledBuild() {
1448 ctx.AddVariationDependencies(nil, usesLibTag, u.usesLibraryProperties.Uses_libs...)
1449 ctx.AddVariationDependencies(nil, usesLibTag, u.presentOptionalUsesLibs(ctx)...)
Paul Duffin250e6192019-06-07 10:44:37 +01001450 // Only add these extra dependencies if the module depends on framework libs. This avoids
1451 // creating a cyclic dependency:
1452 // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
1453 if hasFrameworkLibs {
Colin Cross3245b2c2019-06-07 13:18:09 -07001454 // dexpreopt/dexpreopt.go needs the paths to the dex jars of these libraries in case construct_context.sh needs
1455 // to pass them to dex2oat. Add them as a dependency so we can determine the path to the dex jar of each
1456 // library to dexpreopt.
1457 ctx.AddVariationDependencies(nil, usesLibTag,
1458 "org.apache.http.legacy",
1459 "android.hidl.base-V1.0-java",
1460 "android.hidl.manager-V1.0-java")
1461 }
Colin Cross50ddcc42019-05-16 12:28:22 -07001462 }
1463}
1464
1465// presentOptionalUsesLibs returns optional_uses_libs after filtering out MissingUsesLibraries, which don't exist in the
1466// build.
1467func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
1468 optionalUsesLibs, _ := android.FilterList(u.usesLibraryProperties.Optional_uses_libs, ctx.Config().MissingUsesLibraries())
1469 return optionalUsesLibs
1470}
1471
1472// usesLibraryPaths returns a map of module names of shared library dependencies to the paths to their dex jars.
1473func (u *usesLibrary) usesLibraryPaths(ctx android.ModuleContext) map[string]android.Path {
1474 usesLibPaths := make(map[string]android.Path)
1475
1476 if !ctx.Config().UnbundledBuild() {
1477 ctx.VisitDirectDepsWithTag(usesLibTag, func(m android.Module) {
1478 if lib, ok := m.(Dependency); ok {
1479 if dexJar := lib.DexJar(); dexJar != nil {
1480 usesLibPaths[ctx.OtherModuleName(m)] = dexJar
1481 } else {
1482 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must produce a dex jar, does it have installable: true?",
1483 ctx.OtherModuleName(m))
1484 }
1485 } else if ctx.Config().AllowMissingDependencies() {
1486 ctx.AddMissingDependencies([]string{ctx.OtherModuleName(m)})
1487 } else {
1488 ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library",
1489 ctx.OtherModuleName(m))
1490 }
1491 })
1492 }
1493
1494 return usesLibPaths
1495}
1496
1497// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
1498// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
1499// unconditionally in the future.
1500func (u *usesLibrary) enforceUsesLibraries() bool {
1501 defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
1502 len(u.usesLibraryProperties.Optional_uses_libs) > 0
1503 return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, defaultEnforceUsesLibs)
1504}
1505
1506// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against the ones specified
1507// in the uses_libs and optional_uses_libs properties. It returns the path to a copy of the manifest.
1508func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path {
1509 outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
1510
1511 rule := android.NewRuleBuilder()
Colin Crossee94d6a2019-07-08 17:08:34 -07001512 cmd := rule.Command().BuiltTool(ctx, "manifest_check").
Colin Cross50ddcc42019-05-16 12:28:22 -07001513 Flag("--enforce-uses-libraries").
1514 Input(manifest).
1515 FlagWithOutput("-o ", outputFile)
1516
1517 for _, lib := range u.usesLibraryProperties.Uses_libs {
1518 cmd.FlagWithArg("--uses-library ", lib)
1519 }
1520
1521 for _, lib := range u.usesLibraryProperties.Optional_uses_libs {
1522 cmd.FlagWithArg("--optional-uses-library ", lib)
1523 }
1524
1525 rule.Build(pctx, ctx, "verify_uses_libraries", "verify <uses-library>")
1526
1527 return outputFile
1528}
1529
1530// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the ones specified
1531// in the uses_libs and optional_uses_libs properties. It returns the path to a copy of the APK.
1532func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) android.Path {
1533 outputFile := android.PathForModuleOut(ctx, "verify_uses_libraries", apk.Base())
1534
1535 rule := android.NewRuleBuilder()
1536 aapt := ctx.Config().HostToolPath(ctx, "aapt")
1537 rule.Command().
1538 Textf("aapt_binary=%s", aapt.String()).Implicit(aapt).
1539 Textf(`uses_library_names="%s"`, strings.Join(u.usesLibraryProperties.Uses_libs, " ")).
1540 Textf(`optional_uses_library_names="%s"`, strings.Join(u.usesLibraryProperties.Optional_uses_libs, " ")).
1541 Tool(android.PathForSource(ctx, "build/make/core/verify_uses_libraries.sh")).Input(apk)
1542 rule.Command().Text("cp -f").Input(apk).Output(outputFile)
1543
1544 rule.Build(pctx, ctx, "verify_uses_libraries", "verify <uses-library>")
1545
1546 return outputFile
1547}