| commit | a1d8fa99616a079b586a751d545b6881085714fe | [log] [tgz] |
|---|---|---|
| author | Kousik Kumar <kousikk@google.com> | Fri Mar 18 02:50:31 2022 -0400 |
| committer | Kousik Kumar <kousikk@google.com> | Fri Mar 18 02:53:36 2022 -0400 |
| tree | 599ed5f0025785e009cc7a98c4eecec2e0ea6d2d | |
| parent | 2d6e6a13380284c94122b97ded26c0d80a31ac47 [diff] [blame] |
Do not dump metrics if reproxy was never started Dumping of RBE metrics should only happen when reproxy was started. Reproxy is started only when Soong is run in make / build mode and not in dumpvars mode. Doc: https://docs.google.com/document/d/1Iqhu5QgozB_rA9fucMHO6X4U6A8e8qFtZyub9j83ICQ/edit# Test: Ran a build with / without RBE. No metrics dumped during lunch without RBE and metrics dumping worked as expected with RBE. Bug: b/197213143 Change-Id: Ic3403331e1f4ac2c7c72fd9169aa7b82a7545c75
diff --git a/ui/build/build.go b/ui/build/build.go index 2e44aaa..d261f89 100644 --- a/ui/build/build.go +++ b/ui/build/build.go
@@ -264,6 +264,7 @@ if config.StartRBE() { startRBE(ctx, config) + defer DumpRBEMetrics(ctx, config, filepath.Join(config.LogsDir(), "rbe_metrics.pb")) } if what&RunProductConfig != 0 {