Set NoWarningsAsErrorsInTidyFlags
* Reject -warnings-as-errors in the tidy_flags.
* Fix one grammar error in comment.
Bug: 229801437
Test: WITH_TIDY=1 make; make tidy-soong_subset
Change-Id: I4fae229add65131b64cd5a1d06507d27198010ed
diff --git a/cc/config/tidy.go b/cc/config/tidy.go
index c893320..674edad 100644
--- a/cc/config/tidy.go
+++ b/cc/config/tidy.go
@@ -20,7 +20,7 @@
)
var (
- // Some clang-tidy checks have bugs or not work for Android.
+ // Some clang-tidy checks have bugs or don't work for Android.
// They are disabled here, overriding any locally selected checks.
globalNoCheckList = []string{
// https://b.corp.google.com/issues/153464409
diff --git a/cc/tidy.go b/cc/tidy.go
index 94b10c2..6b5d572 100644
--- a/cc/tidy.go
+++ b/cc/tidy.go
@@ -66,7 +66,7 @@
// Set this const to true when all -warnings-as-errors in tidy_flags
// are replaced with tidy_checks_as_errors.
// Then, that old style usage will be obsolete and an error.
-const NoWarningsAsErrorsInTidyFlags = false
+const NoWarningsAsErrorsInTidyFlags = true
func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {
CheckBadTidyFlags(ctx, "tidy_flags", tidy.Properties.Tidy_flags)