Have pom2mk include runtime deps too
It still excludes test deps though
Bug: 76692459
Test: ./update_current.py -x <build-id>
Change-Id: I55a786e9feab31f99b95b7cebe84869757e46270
diff --git a/cmd/pom2mk/pom2mk.go b/cmd/pom2mk/pom2mk.go
index 4fc484c..5842f70 100644
--- a/cmd/pom2mk/pom2mk.go
+++ b/cmd/pom2mk/pom2mk.go
@@ -89,6 +89,16 @@
var useVersion string
var staticDeps bool
+func InList(s string, list []string) bool {
+ for _, l := range list {
+ if l == s {
+ return true
+ }
+ }
+
+ return false
+}
+
type Dependency struct {
XMLName xml.Name `xml:"dependency"`
@@ -139,19 +149,19 @@
}
func (p Pom) MkJarDeps() []string {
- return p.MkDeps("jar", "compile")
+ return p.MkDeps("jar", []string{"compile", "runtime"})
}
func (p Pom) MkAarDeps() []string {
- return p.MkDeps("aar", "compile")
+ return p.MkDeps("aar", []string{"compile", "runtime"})
}
// MkDeps obtains dependencies filtered by type and scope. The results of this
// method are formatted as Make targets, e.g. run through MavenToMk rules.
-func (p Pom) MkDeps(typeExt string, scope string) []string {
+func (p Pom) MkDeps(typeExt string, scopes []string) []string {
var ret []string
for _, d := range p.Dependencies {
- if d.Type != typeExt || d.Scope != scope {
+ if d.Type != typeExt || !InList(d.Scope, scopes) {
continue
}
name := rewriteNames.MavenToMk(d.GroupId, d.ArtifactId)
@@ -363,7 +373,6 @@
if old, ok := modules[key]; ok {
fmt.Fprintln(os.Stderr, "Module", key, "defined twice:", old.PomFile, pom.PomFile)
- os.Exit(1)
}
modules[key] = pom