Create a temporary denylist for go binaries used in mixed builds
This allows us to rollout building _some_ go targets using rules_go
without affecting mixed builds.
Test: Presubmit
Bug: 284483729
Change-Id: I0ccb4c9b90614369147a380f44f7ae372ef9396e
diff --git a/bp2build/build_conversion.go b/bp2build/build_conversion.go
index 265a368..9921a7f 100644
--- a/bp2build/build_conversion.go
+++ b/bp2build/build_conversion.go
@@ -464,6 +464,17 @@
return []BazelTarget{binTarget}, nil
}
+var (
+ // TODO - b/284483729: Remove this denyilst
+ // Temporary denylist of go binaries that are currently used in mixed builds
+ // This denylist allows us to rollout bp2build converters for go targets without affecting mixed builds
+ goBinaryDenylist = []string{
+ "soong_zip",
+ "zip2zip",
+ "bazel_notice_gen",
+ }
+)
+
func GenerateBazelTargets(ctx *CodegenContext, generateFilegroups bool) (conversionResults, []error) {
buildFileToTargets := make(map[string]BazelTargets)
@@ -556,7 +567,7 @@
targets, targetErrs = generateBazelTargetsGoPackage(bpCtx, glib, nameToGoLibMap)
errs = append(errs, targetErrs...)
metrics.IncrementRuleClassCount("go_library")
- } else if gbin, ok := m.(*bootstrap.GoBinary); ok {
+ } else if gbin, ok := m.(*bootstrap.GoBinary); ok && !android.InList(m.Name(), goBinaryDenylist) {
targets, targetErrs = generateBazelTargetsGoBinary(bpCtx, gbin, nameToGoLibMap)
errs = append(errs, targetErrs...)
metrics.IncrementRuleClassCount("go_binary")