Support testing Rules in Modules and Rules and Builds in Singletons
Add support for TestingModule to return RuleParams for rules created
by the module.
Refactor TestingModule to use helpers, and use the helpers to
implement a similar TestingSingleton.
Use the new functionality to test RuleBuilder's module and singleton
rules.
Test: none
Change-Id: I8348c56ff5086d0c49401f5a00faf7c864e6b6f3
diff --git a/android/rule_builder_test.go b/android/rule_builder_test.go
index f738faf..f157ab7 100644
--- a/android/rule_builder_test.go
+++ b/android/rule_builder_test.go
@@ -364,17 +364,26 @@
_, errs = ctx.PrepareBuildActions(config)
FailIfErrored(t, errs)
- foo := ctx.ModuleForTests("foo", "").Rule("rule")
+ check := func(t *testing.T, params TestingBuildParams, wantOutput string) {
+ if len(params.RuleParams.CommandDeps) != 1 || params.RuleParams.CommandDeps[0] != "cp" {
+ t.Errorf("want RuleParams.CommandDeps = [%q], got %q", "cp", params.RuleParams.CommandDeps)
+ }
- // TODO: make RuleParams accessible to tests and verify rule.Command().Tools() ends up in CommandDeps
+ if len(params.Implicits) != 1 || params.Implicits[0].String() != "bar" {
+ t.Errorf("want Implicits = [%q], got %q", "bar", params.Implicits.Strings())
+ }
- if len(foo.Implicits) != 1 || foo.Implicits[0].String() != "bar" {
- t.Errorf("want foo.Implicits = [%q], got %q", "bar", foo.Implicits.Strings())
+ if len(params.Outputs) != 1 || params.Outputs[0].String() != wantOutput {
+ t.Errorf("want Outputs = [%q], got %q", wantOutput, params.Outputs.Strings())
+ }
}
- wantOutput := filepath.Join(buildDir, ".intermediates", "foo", "foo")
- if len(foo.Outputs) != 1 || foo.Outputs[0].String() != wantOutput {
- t.Errorf("want foo.Outputs = [%q], got %q", wantOutput, foo.Outputs.Strings())
- }
-
+ t.Run("module", func(t *testing.T) {
+ check(t, ctx.ModuleForTests("foo", "").Rule("rule"),
+ filepath.Join(buildDir, ".intermediates", "foo", "foo"))
+ })
+ t.Run("singleton", func(t *testing.T) {
+ check(t, ctx.SingletonForTests("rule_builder_test").Rule("rule"),
+ filepath.Join(buildDir, "baz"))
+ })
}