| commit | 315a53c5cb5af5d354a56f5229f546e7ed9ff1c1 | [log] [tgz] |
|---|---|---|
| author | Yu Liu <yudiliu@google.com> | Wed Apr 24 16:41:57 2024 +0000 |
| committer | Android Build Cherrypicker Worker <android-build-cherrypicker-worker@google.com> | Wed Apr 24 16:41:57 2024 +0000 |
| tree | 978d24aa4cb46d19582664487dc75d73fa64b0b4 | |
| parent | b39c877ae058b6217f416783453b7433fd969494 [diff] [blame] |
Make container mandatory in aconfig_declarations. Bug: 330354107 Test: Unit test and CI. Ignore-AOSP-First: It is easier to detect all the missing ones in internal master. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e916a2c758d2a95037d1d366e7cd0e10d241d510) Merged-In: I4ab4271c67a35d0fdcc0b57c27260e29fb7dea56 Change-Id: I4ab4271c67a35d0fdcc0b57c27260e29fb7dea56
diff --git a/aconfig/aconfig_declarations.go b/aconfig/aconfig_declarations.go index d29e312..71a64dd 100644 --- a/aconfig/aconfig_declarations.go +++ b/aconfig/aconfig_declarations.go
@@ -73,8 +73,9 @@ if len(module.properties.Package) == 0 { ctx.PropertyErrorf("package", "missing package property") } - // TODO(b/311155208): Add mandatory check for container after all pre-existing - // ones are changed. + if len(module.properties.Container) == 0 { + ctx.PropertyErrorf("container", "missing container property") + } // Add a dependency on the aconfig_value_sets defined in // RELEASE_ACONFIG_VALUE_SETS, and add any aconfig_values that