Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2024 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | package com.android.checkflaggedapis |
| 17 | |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 18 | import android.aconfig.Aconfig |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 19 | import android.aconfig.Aconfig.flag_state.DISABLED |
| 20 | import android.aconfig.Aconfig.flag_state.ENABLED |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 21 | import java.io.ByteArrayInputStream |
| 22 | import java.io.ByteArrayOutputStream |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 23 | import java.io.InputStream |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 24 | import org.junit.Assert.assertEquals |
Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 25 | import org.junit.Test |
| 26 | import org.junit.runner.RunWith |
Mårten Kongstad | 7cc2174 | 2024-04-18 10:23:20 +0200 | [diff] [blame] | 27 | import org.junit.runners.JUnit4 |
Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 28 | |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 29 | private val API_SIGNATURE = |
| 30 | """ |
| 31 | // Signature format: 2.0 |
| 32 | package android { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 33 | @FlaggedApi("android.flag.foo") public final class Clazz { |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 34 | ctor @FlaggedApi("android.flag.foo") public Clazz(); |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 35 | field @FlaggedApi("android.flag.foo") public static final int FOO = 1; // 0x1 |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 36 | method @FlaggedApi("android.flag.foo") public int getErrorCode(); |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 37 | method @FlaggedApi("android.flag.foo") public boolean setData(int, int[][], @NonNull android.util.Utility<T, U>); |
| 38 | method @FlaggedApi("android.flag.foo") public boolean setVariableData(int, android.util.Atom...); |
| 39 | method @FlaggedApi("android.flag.foo") public boolean innerClassArg(android.Clazz.Builder); |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 40 | } |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 41 | @FlaggedApi("android.flag.bar") public static class Clazz.Builder { |
| 42 | } |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 43 | } |
| 44 | """ |
| 45 | .trim() |
| 46 | |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 47 | private val API_VERSIONS = |
| 48 | """ |
| 49 | <?xml version="1.0" encoding="utf-8"?> |
| 50 | <api version="3"> |
| 51 | <class name="android/Clazz" since="1"> |
| 52 | <method name="<init>()V"/> |
| 53 | <field name="FOO"/> |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 54 | <method name="getErrorCode()I"/> |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 55 | <method name="setData(I[[ILandroid/util/Utility;)Z"/> |
| 56 | <method name="setVariableData(I[Landroid/util/Atom;)Z"/> |
| 57 | <method name="innerClassArg(Landroid/Clazz${"$"}Builder;)"/> |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 58 | </class> |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 59 | <class name="android/Clazz${"$"}Builder" since="2"> |
| 60 | </class> |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 61 | </api> |
| 62 | """ |
| 63 | .trim() |
| 64 | |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 65 | private fun generateFlagsProto( |
| 66 | fooState: Aconfig.flag_state, |
| 67 | barState: Aconfig.flag_state |
| 68 | ): InputStream { |
| 69 | val fooFlag = |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 70 | Aconfig.parsed_flag |
| 71 | .newBuilder() |
| 72 | .setPackage("android.flag") |
| 73 | .setName("foo") |
| 74 | .setState(fooState) |
| 75 | .setPermission(Aconfig.flag_permission.READ_ONLY) |
| 76 | .build() |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 77 | val barFlag = |
| 78 | Aconfig.parsed_flag |
| 79 | .newBuilder() |
| 80 | .setPackage("android.flag") |
| 81 | .setName("bar") |
| 82 | .setState(barState) |
| 83 | .setPermission(Aconfig.flag_permission.READ_ONLY) |
| 84 | .build() |
| 85 | val flags = |
| 86 | Aconfig.parsed_flags.newBuilder().addParsedFlag(fooFlag).addParsedFlag(barFlag).build() |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 87 | val binaryProto = ByteArrayOutputStream() |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 88 | flags.writeTo(binaryProto) |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 89 | return ByteArrayInputStream(binaryProto.toByteArray()) |
| 90 | } |
| 91 | |
Mårten Kongstad | 7cc2174 | 2024-04-18 10:23:20 +0200 | [diff] [blame] | 92 | @RunWith(JUnit4::class) |
| 93 | class CheckFlaggedApisTest { |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 94 | @Test |
| 95 | fun testParseApiSignature() { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 96 | val expected = |
| 97 | setOf( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 98 | Pair(Symbol.createClass("android/Clazz"), Flag("android.flag.foo")), |
| 99 | Pair(Symbol.createMethod("android/Clazz", "Clazz()"), Flag("android.flag.foo")), |
| 100 | Pair(Symbol.createField("android/Clazz", "FOO"), Flag("android.flag.foo")), |
| 101 | Pair(Symbol.createMethod("android/Clazz", "getErrorCode()"), Flag("android.flag.foo")), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 102 | Pair( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 103 | Symbol.createMethod("android/Clazz", "setData(I[[ILandroid/util/Utility;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 104 | Flag("android.flag.foo")), |
| 105 | Pair( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 106 | Symbol.createMethod("android/Clazz", "setVariableData(I[Landroid/util/Atom;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 107 | Flag("android.flag.foo")), |
| 108 | Pair( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 109 | Symbol.createMethod("android/Clazz", "innerClassArg(Landroid/Clazz/Builder;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 110 | Flag("android.flag.foo")), |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 111 | Pair(Symbol.createClass("android/Clazz/Builder"), Flag("android.flag.bar")), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 112 | ) |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 113 | val actual = parseApiSignature("in-memory", API_SIGNATURE.byteInputStream()) |
| 114 | assertEquals(expected, actual) |
| 115 | } |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 116 | |
| 117 | @Test |
| 118 | fun testParseFlagValues() { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 119 | val expected: Map<Flag, Boolean> = |
| 120 | mapOf(Flag("android.flag.foo") to true, Flag("android.flag.bar") to true) |
| 121 | val actual = parseFlagValues(generateFlagsProto(ENABLED, ENABLED)) |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 122 | assertEquals(expected, actual) |
| 123 | } |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 124 | |
| 125 | @Test |
| 126 | fun testParseApiVersions() { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 127 | val expected: Set<Symbol> = |
| 128 | setOf( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 129 | Symbol.createClass("android/Clazz"), |
| 130 | Symbol.createMethod("android/Clazz", "Clazz()"), |
| 131 | Symbol.createField("android/Clazz", "FOO"), |
| 132 | Symbol.createMethod("android/Clazz", "getErrorCode()"), |
| 133 | Symbol.createMethod("android/Clazz", "setData(I[[ILandroid/util/Utility;)"), |
| 134 | Symbol.createMethod("android/Clazz", "setVariableData(I[Landroid/util/Atom;)"), |
| 135 | Symbol.createMethod("android/Clazz", "innerClassArg(Landroid/Clazz/Builder;)"), |
| 136 | Symbol.createClass("android/Clazz/Builder"), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 137 | ) |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 138 | val actual = parseApiVersions(API_VERSIONS.byteInputStream()) |
| 139 | assertEquals(expected, actual) |
| 140 | } |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 141 | |
| 142 | @Test |
Mårten Kongstad | 02525a8 | 2024-05-06 10:28:02 +0200 | [diff] [blame] | 143 | fun testParseApiVersionsNestedClasses() { |
| 144 | val apiVersions = |
| 145 | """ |
| 146 | <?xml version="1.0" encoding="utf-8"?> |
| 147 | <api version="3"> |
| 148 | <class name="android/Clazz${'$'}Foo${'$'}Bar" since="1"> |
| 149 | <method name="<init>()V"/> |
| 150 | </class> |
| 151 | </api> |
| 152 | """ |
| 153 | .trim() |
| 154 | val expected: Set<Symbol> = |
| 155 | setOf( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 156 | Symbol.createClass("android/Clazz/Foo/Bar"), |
| 157 | Symbol.createMethod("android/Clazz/Foo/Bar", "Bar()"), |
Mårten Kongstad | 02525a8 | 2024-05-06 10:28:02 +0200 | [diff] [blame] | 158 | ) |
| 159 | val actual = parseApiVersions(apiVersions.byteInputStream()) |
| 160 | assertEquals(expected, actual) |
| 161 | } |
| 162 | |
| 163 | @Test |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 164 | fun testFindErrorsNoErrors() { |
| 165 | val expected = setOf<ApiError>() |
| 166 | val actual = |
| 167 | findErrors( |
| 168 | parseApiSignature("in-memory", API_SIGNATURE.byteInputStream()), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 169 | parseFlagValues(generateFlagsProto(ENABLED, ENABLED)), |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 170 | parseApiVersions(API_VERSIONS.byteInputStream())) |
| 171 | assertEquals(expected, actual) |
| 172 | } |
| 173 | |
| 174 | @Test |
| 175 | fun testFindErrorsDisabledFlaggedApiIsPresent() { |
| 176 | val expected = |
| 177 | setOf<ApiError>( |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 178 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 179 | Symbol.createClass("android/Clazz"), Flag("android.flag.foo")), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 180 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 181 | Symbol.createMethod("android/Clazz", "Clazz()"), Flag("android.flag.foo")), |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 182 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 183 | Symbol.createField("android/Clazz", "FOO"), Flag("android.flag.foo")), |
| 184 | DisabledFlaggedApiIsPresentError( |
| 185 | Symbol.createMethod("android/Clazz", "getErrorCode()"), Flag("android.flag.foo")), |
| 186 | DisabledFlaggedApiIsPresentError( |
| 187 | Symbol.createMethod("android/Clazz", "setData(I[[ILandroid/util/Utility;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 188 | Flag("android.flag.foo")), |
| 189 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 190 | Symbol.createMethod("android/Clazz", "setVariableData(I[Landroid/util/Atom;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 191 | Flag("android.flag.foo")), |
| 192 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 193 | Symbol.createMethod("android/Clazz", "innerClassArg(Landroid/Clazz/Builder;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 194 | Flag("android.flag.foo")), |
| 195 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame^] | 196 | Symbol.createClass("android/Clazz/Builder"), Flag("android.flag.bar")), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 197 | ) |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 198 | val actual = |
| 199 | findErrors( |
| 200 | parseApiSignature("in-memory", API_SIGNATURE.byteInputStream()), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 201 | parseFlagValues(generateFlagsProto(DISABLED, DISABLED)), |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 202 | parseApiVersions(API_VERSIONS.byteInputStream())) |
| 203 | assertEquals(expected, actual) |
| 204 | } |
Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 205 | } |