commit fea4263ec19fcdad39d21a9700570f5cd0159342
author Treehugger Robot <treehugger-gerrit@google.com> Thu Oct 25 22:35:37 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Oct 25 22:35:37 2018 +0000
tree 10cee30720f5bc4b3a980781bbb9b8b154ee9674
parent 1bc81731c8c49e66601519cd39e2182e666f7e11
parent f3fc62c8a0b35e9aad5538bc8eb10cdc6db334b4

Merge "releasetools: Fix the error message."

tools/releasetools/build_image.py

diff --git a/tools/releasetools/build_image.py b/tools/releasetools/build_image.py
index d731842..b88171f 100755
--- a/tools/releasetools/build_image.py
+++ b/tools/releasetools/build_image.py
@@ -58,15 +58,9 @@
 
   Returns:
     The number of bytes based on a 1K block_size.
-
-  Raises:
-    BuildImageError: On error.
   """
   cmd = ["du", "-k", "-s", path]
-  try:
-    output = common.RunAndCheckOutput(cmd, verbose=False)
-  except common.ExternalError:
-    raise BuildImageError("Failed to get disk usage:\n{}".format(output))
+  output = common.RunAndCheckOutput(cmd, verbose=False)
   return int(output.split()[0]) * 1024
 
 
@@ -78,15 +72,9 @@
 
   Returns:
     The number of inodes used.
-
-  Raises:
-    BuildImageError: On error.
   """
   cmd = ["find", path, "-print"]
-  try:
-    output = common.RunAndCheckOutput(cmd, verbose=False)
-  except common.ExternalError:
-    raise BuildImageError("Failed to get disk inode usage:\n{}".format(output))
+  output = common.RunAndCheckOutput(cmd, verbose=False)
   # increase by > 4% as number of files and directories is not whole picture.
   return output.count('\n') * 25 // 24
 
@@ -99,19 +87,15 @@
 
   Returns:
     The characteristics dictionary.
-
-  Raises:
-    BuildImageError: On error.
   """
   unsparse_image_path = UnsparseImage(sparse_image_path, replace=False)
 
   cmd = ["tune2fs", "-l", unsparse_image_path]
   try:
     output = common.RunAndCheckOutput(cmd, verbose=False)
-  except common.ExternalError:
-    raise BuildImageError("Failed to get tune2fs usage:\n{}".format(output))
-  os.remove(unsparse_image_path)
-  fs_dict = { }
+  finally:
+    os.remove(unsparse_image_path)
+  fs_dict = {}
   for line in output.splitlines():
     fields = line.split(":")
     if len(fields) == 2: