commit ecef6fa224c2f65ffa012c72851815b18b76ea6f
author Yifan Hong <elsk@google.com> Tue Jul 20 02:59:47 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Jul 20 02:59:47 2021 +0000
tree f8ada593c9ec3988a69fd1751dfc5131a153b1f7
parent 28176b66ba45d45efab98d60ae73fca83ea8dcbe
parent f32f65c5a441b536c36c7361a42742841d6b61e6

Merge changes from topic "ota-package-nonab"

* changes:
  Only build OTA package for non-A/B with recovery
  Reland "Build OTA when boot image exists even without kernel or recovery fstab"

core/Makefile

diff --git a/core/Makefile b/core/Makefile
index 5a387e0..b44d1d7 100644
--- a/core/Makefile
+++ b/core/Makefile
@@ -4235,13 +4235,22 @@
   ifeq ($(TARGET_PRODUCT),sdk)
     build_ota_package := false
   endif
+  # A target without a kernel may be one of the following:
+  # - A generic target. In this case, the OTA package usually isn't built.
+  #   PRODUCT_BUILD_GENERIC_OTA_PACKAGE may be set to true to force OTA package
+  #   generation.
+  # - A real device target, with TARGET_NO_KERNEL set to true and
+  #   BOARD_PREBUILT_BOOTIMAGE set. In this case, it is valid to generate
+  #   an OTA package.
   ifneq ($(PRODUCT_BUILD_GENERIC_OTA_PACKAGE),true)
     ifneq ($(filter generic%,$(TARGET_DEVICE)),)
       build_ota_package := false
     endif
-    ifeq ($(TARGET_NO_KERNEL),true)
-      build_ota_package := false
-    endif
+    ifeq ($(INSTALLED_BOOTIMAGE_TARGET),)
+      ifeq ($(TARGET_NO_KERNEL),true)
+        build_ota_package := false
+      endif
+    endif # INSTALLED_BOOTIMAGE_TARGET == ""
     ifeq ($(recovery_fstab),)
       build_ota_package := false
     endif