commit b820bcd8291fd1c6870d0f8d5fb20d3b71d25da2
author Cole Faust <colefaust@google.com> Thu Oct 28 13:59:48 2021 -0700
committer Cole Faust <colefaust@google.com> Thu Nov 04 17:58:44 2021 -0700
tree bb0dab243c2557186c9a04acbe635d5c641cf0b7
parent 936e704999b699b7d3fe01215484662a413ad8e7

Prepare release tools for python 3

- Sort dictionaries before looping over them
- Don't call sorted() on lists with Nones
- Open file in binary format when serializing protobufs

Change-Id: If5dbc908f7125f6184014b3c1c7891f833d1d8bf
Bug: 203436762
Test: Presubmits

tools/releasetools/ota_utils.py

diff --git a/tools/releasetools/ota_utils.py b/tools/releasetools/ota_utils.py
index 5737009..6c5fc05 100644
--- a/tools/releasetools/ota_utils.py
+++ b/tools/releasetools/ota_utils.py
@@ -154,7 +154,7 @@
                 compress_type=zipfile.ZIP_STORED)
     return
 
-  with open('{}.pb'.format(output), 'w') as f:
+  with open('{}.pb'.format(output), 'wb') as f:
     f.write(metadata_proto.SerializeToString())
   with open(output, 'w') as f:
     f.write(legacy_metadata)