| commit | 27f601f5d96bb6b94233169ae8a29ea4290e6904 | [log] [tgz] |
|---|---|---|
| author | Steven Moreland <smoreland@google.com> | Thu May 23 00:00:08 2024 +0000 |
| committer | Steven Moreland <smoreland@google.com> | Fri May 24 21:59:35 2024 +0000 |
| tree | 56b37f2abe7bcc65fe456f2a908212b9ed559eb3 | |
| parent | bdb6b87837135a69f35f9abe28658ce2cdf179e2 [diff] |
Consider non-shipping lunch targets to be future.
Many places in the codebase have checks like this:
if shipping level > X: do cool thing Y
This is great because it reduces the cost to upgrade and test
old Android devices or refactor their code. However, many
targets, such as the NDK, the SDK, mainline modules, and so on
do not set a shipping level, so they don't get to do the cool
thing Y.
In order to resolve this, we could modify every check to check
the default case. However, this is an invasive change, and it
is not maintainable. Instead, consider non-shipping products to
always be in the future.
In general, Android features are required to be backwards
compatible, so this should always work for things like mainline.
Also note, this means when someone adds a new feature Y like this,
they'll clearly see the impact of it being added everywhere, rather
than on such a small selection of newly shipping devices. This
avoids a risk where a change needs to be run on mainline modules (or
other targets) but is not tested in this configuration from the
start.
Future work: many `ifndef` checks can be cleaned up after this,
or if this approach makes sense, they can be cleaned up in this
CL.
Bug: 339026799
Bug: 279808973
Bug: 333908433
Test: builds of:
- errorprone-trunk_staging
- mainline_modules_sdks-trunk_staging-userdebug
- mainline_modules_x86_64-trunk_staging-userdebug
- ndk
- sdk-trunk_staging-userdebug
Test: too large number gives:
build/make/core/product_config.mk:598: error: integer greater than 10001 is not supported!.
Change-Id: I17c34267f774ea8b9265e1d798a67af7838715c5
This is the Makefile-based portion of the Android Build System.
For documentation on how to run a build, see Usage.txt
For a list of behavioral changes useful for Android.mk writers see Changes.md
For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.
This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.