commit 8fdda6e495dbb290e436195b5b386ecd30490246
author Chih-Hung Hsieh <chh@google.com> Sun Oct 02 21:31:04 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Tue Oct 04 10:18:02 2016 -0700
tree 16e7999b812bef1be438e5e11e737ea99ca4ca31
parent 312c310f7c31d849aa05ce4d41229c4665a15d6a

Accept environment variables DEFAULT_*_TIDY_CHECKS

* Define DEFAULT_GLOBAL_TIDY_CHECKS/DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS
  only if it is not already defined.

Bug: http://b/27779618
Test: build with WITH_TIDY=1 and define those variables.
Change-Id: I201c9da3769d6ef658a75d4a1bf42ec6816d4069

core/clang/tidy.mk

diff --git a/core/clang/tidy.mk b/core/clang/tidy.mk
index c1d485d..58ecd07 100644
--- a/core/clang/tidy.mk
+++ b/core/clang/tidy.mk
@@ -18,7 +18,7 @@
 # Global tidy checks include only google*, performance*,
 # and misc-macro-parentheses, but not google-readability*
 # or google-runtime-references.
-DEFAULT_GLOBAL_TIDY_CHECKS := \
+DEFAULT_GLOBAL_TIDY_CHECKS ?= \
   $(subst $(space),, \
     -*,google* \
     ,misc-macro-parentheses \
@@ -29,7 +29,7 @@
 
 # There are too many clang-tidy warnings in external and vendor projects.
 # Enable only some google checks for these projects.
-DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS := \
+DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS ?= \
   $(subst $(space),, \
     -*,google* \
     ,-google-build-using-namespace \