commit 692dd32c33f6a096ab6cf5b66953617c9bac8a45
author Julien Desprez <jdesprez@google.com> Wed Dec 11 00:31:02 2024 +0000
committer Julien Desprez <jdesprez@google.com> Wed Dec 11 02:16:23 2024 +0000
tree 9f845c4bb620f9d2ad0f7d483d4d9aae667aa476
parent fad1e47dc06410ab3ea1274c9f46672ca25b0027

Add robustness to possible empty BUILD_CONTEXT

We find possible evidence that BUILD_CONTEXT existed but was incorrectly
empty.
Adding robustness for this for safety while continuing to investigate
the root cause.

Change-Id: I8e9149a97e8cba8291cb41e010d75102a437ad87
Test: presubmit
Bug: 383383586

ci/build_test_suites.py

diff --git a/ci/build_test_suites.py b/ci/build_test_suites.py
index 343a177..a541d89 100644
--- a/ci/build_test_suites.py
+++ b/ci/build_test_suites.py
@@ -72,6 +72,12 @@
     if 'optimized_build' not in self.build_context.enabled_build_features:
       return BuildPlan(set(self.args.extra_targets), set())
 
+    if not self.build_context.test_infos:
+      logging.warning('Build context has no test infos, skipping optimizations.')
+      for target in self.args.extra_targets:
+        get_metrics_agent().report_unoptimized_target(target, 'BUILD_CONTEXT has no test infos.')
+      return BuildPlan(set(self.args.extra_targets), set())
+
     build_targets = set()
     packaging_commands_getters = []
     # In order to roll optimizations out differently between test suites and

ci/build_test_suites_test.py

diff --git a/ci/build_test_suites_test.py b/ci/build_test_suites_test.py
index 29d268e..190740f 100644
--- a/ci/build_test_suites_test.py
+++ b/ci/build_test_suites_test.py
@@ -306,7 +306,8 @@
     build_planner = self.create_build_planner(
         build_targets=build_targets,
         build_context=self.create_build_context(
-            enabled_build_features=[{'name': self.get_target_flag('target_1')}]
+            enabled_build_features=[{'name': self.get_target_flag('target_1')}],
+            test_context=self.get_test_context('target_1'),
         ),
     )
 
@@ -322,7 +323,8 @@
     build_planner = self.create_build_planner(
         build_targets=build_targets,
         build_context=self.create_build_context(
-            enabled_build_features=[{'name': self.get_target_flag('target_1')}]
+            enabled_build_features=[{'name': self.get_target_flag('target_1')}],
+            test_context=self.get_test_context('target_1'),
         ),
         packaging_commands=packaging_commands,
     )