Gitiles
Code Review Sign In
gerrit.omnirom.org / android_build / 4388643d211ea0d4d9002b499f3c122db3fc6923
commit4388643d211ea0d4d9002b499f3c122db3fc6923[log] [tgz]
authorSpandan Das <spandandas@google.com>Tue Jul 16 02:51:26 2024 +0000
committerSpandan Das <spandandas@google.com>Tue Jul 16 18:50:32 2024 +0000
tree99156390e569669a85581af41af83c22f6ad23c8
parent0857a9100095883752a474cc83c8afd41cc27e43 [diff]
Copy odex files from system_other to data/dalvik-cache on first boot

This is currently not the default behavior. products opt-in by
setting ro.cp_system_other_odex=1 (with cuttlefish being the only
product family in internal main that sets this).

With https://r.android.com/3144182, the odex files of system_ext and
product are now installed in system_other. Since the odex files are not
copied to /data, it triggers dexopt on device, which slows down first
boot performance.

This CL changes makes cp_system_other_odex=1 in
build/make/target/product/runtime_libart.mk. This file is inherited by
internal google products and external OEMs, and ensures that the odex
files are copied from system_other to /data/dalvik-cache on first boot.

Test: lunch oriole-trunk_staging-userdebug && get_build_var
PRODUCT_VENDOR_PROPERTIES # verified that this property is set

Test: In logcat, found the following match for `CalendarGooglePrebuilt`
(a /product app)
```
Successfully loaded /data/dalvik-cache/arm64/product@app@CalendarGooglePrebuilt@CalendarGooglePrebuilt.apk@classes.dex with executable: 0
/data/dalvik-cache/arm64/product@app@CalendarGooglePrebuilt@CalendarGooglePrebuilt.apk@classes.dex is kOatUpToDate with filter verify
Dexopt result: [packageName = com.google.android.calendar] DexContainerFileDexoptResult{dexContainerFile=/product/app/CalendarGooglePrebuilt/CalendarGooglePrebuilt.apk, primaryAbi=true, abi=arm64-v8a, actualCompilerFilter=verify, status=SKIPPED, dex2oatWallTimeMillis=0, dex2oatCpuTimeMillis=0, sizeBytes=0, sizeBeforeBytes=0, extendedStatusFlags=[]}

```
Bug: 349083274
Bug: 343367700

Change-Id: I42eda6742adcce7caccb1f2302578c01df8a24fd
1 file changed
tree: 99156390e569669a85581af41af83c22f6ad23c8
  1. ci/
  2. common/
  3. core/
  4. packaging/
  5. target/
  6. teams/
  7. tests/
  8. tools/
  9. .gitignore
  10. Android.bp
  11. banchanHelp.sh
  12. buildspec.mk.default
  13. Changes.md
  14. CleanSpec.mk
  15. cogsetup.sh
  16. Deprecation.md
  17. envsetup.sh
  18. help.sh
  19. navbar.md
  20. OWNERS
  21. PREUPLOAD.cfg
  22. rbesetup.sh
  23. README.md
  24. shell_utils.sh
  25. tapasHelp.sh
  26. Usage.txt
README.md

Android Make Build System

This is the Makefile-based portion of the Android Build System.

For documentation on how to run a build, see Usage.txt

For a list of behavioral changes useful for Android.mk writers see Changes.md

For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.

This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.