commit 2e4fdbdda1a5ffba53ed025e6d04a16d40003325
author Chih-Hung Hsieh <chh@google.com> Wed Feb 10 22:15:31 2021 -0800
committer Chih-Hung Hsieh <chh@google.com> Thu Feb 11 22:36:04 2021 -0800
tree af843fb7c4b0c3b54c6d1fae6960eed83ae0317c
parent 836c0917560de959f4d4bce0c0edf1196fc90b46

Do not append empty DEFAULT_TIDY_HEADER_DIRS

* Default value will be empty and not work in -header-filter.

Bug: 179530304
Test: make with WITH_TIDY=1 and various setting of DEFAULT_TIDY_HEADER_DIRS
Change-Id: I3f784f545acd12285a5bf6dcae1bab42c9185fe7

core/clang/tidy.mk

diff --git a/core/clang/tidy.mk b/core/clang/tidy.mk
index 868f7bc..8a40878 100644
--- a/core/clang/tidy.mk
+++ b/core/clang/tidy.mk
@@ -36,7 +36,7 @@
 )
 endef
 
-# Default filter contains current directory $1 and DEFAULT_TIDY_HEADER_DIRS.
+# Default filter contains current directory $1 and optional DEFAULT_TIDY_HEADER_DIRS.
 define default_tidy_header_filter
-  -header-filter="($(subst $(space),,$1|$(DEFAULT_TIDY_HEADER_DIRS)))"
+  -header-filter=$(if $(DEFAULT_TIDY_HEADER_DIRS),"($1/|$(DEFAULT_TIDY_HEADER_DIRS))",$1/)
 endef