| commit | f2c78addd495210722e8138c67444dd5419e9b7b | [log] [tgz] |
|---|---|---|
| author | Nick Kralevich <nnk@google.com> | Wed Feb 12 13:27:40 2025 -0800 |
| committer | Nick Kralevich <nnk@google.com> | Wed Feb 12 13:28:05 2025 -0800 |
| tree | b731331386cff770b8f407d15dfae549a5aa12f8 | |
| parent | b664c8eb244c4f5c415e1db7062ab344ab4fbc4c [diff] |
Use -target-feature for MTE
Instead of setting -march, use clang's -target-feature functionality
to enable MTE. Some projects set -march which may conflict with MTE's
usage. Using -target-feature to enable MTE removes any clang command
line ordering issues.
History:
* Originally submitted as 3340cf27f76a94b1536e66e5847b11e334c97b85
* reverted in 32721f125b1ed0db3fbd434c2412dcf1f1e146e9 due to
bug 371029823
* Prematurely resubmitted as fe67d8f1f22106bcc6634652ea1a5303e406f639
and then subsequently reverted in
476da833e12179d31f6a301ad65bf45c63a28818 as the fix for bug 371029823
had not yet landed.
Fixes the following compile failures on _fullmte builds:
vendor/google/services/LyricCameraHAL/src/lyric/api/algo/data_types/local_tone_mapping_data_v1.cc
vendor/google/services/LyricCameraHAL/src/lyric/api/algo/data_types/local_tone_mapping_data_v1.cc:209:34: error: always_inline function 'vpaddq_f16' requires target feature 'fullfp16', but would be inlined into function 'GridMeanNeon' that is compiled without support for 'fullfp16'
209 | vmulq_f16(norm, vpaddq_f16(vpaddq_f16(slope_bias[0], slope_bias[1]),
| ^
vendor/google/services/LyricCameraHAL/src/lyric/api/algo/data_types/local_tone_mapping_data_v1.cc:210:34: error: always_inline function 'vpaddq_f16' requires target feature 'fullfp16', but would be inlined into function 'GridMeanNeon' that is compiled without support for 'fullfp16'
210 | vpaddq_f16(slope_bias[2], slope_bias[3])));
Bug: 366222162
Test: compiles and boots
Change-Id: I821b310908dd9ff2aeaa81459762286590337eaf
This is the Makefile-based portion of the Android Build System.
For documentation on how to run a build, see Usage.txt
For a list of behavioral changes useful for Android.mk writers see Changes.md
For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.
This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.