Handle AF_PACKET in getifaddr(3).
Also fix a bug where we were mutating the address/broadcast address
of an existing entry rather than the new entry, and use 'const' to
ensure we don't make that mistake again.
Change-Id: I31c127a5d21879b52c85cd0f7ed2e66554a21e39
diff --git a/tests/ifaddrs_test.cpp b/tests/ifaddrs_test.cpp
index 67857cb..bbaaec3 100644
--- a/tests/ifaddrs_test.cpp
+++ b/tests/ifaddrs_test.cpp
@@ -18,6 +18,9 @@
#include <ifaddrs.h>
+#include <linux/if_packet.h>
+#include <netinet/in.h>
+
TEST(ifaddrs, freeifaddrs_null) {
freeifaddrs(nullptr);
}
@@ -28,11 +31,33 @@
ASSERT_EQ(0, getifaddrs(&addrs));
ASSERT_TRUE(addrs != nullptr);
- bool saw_loopback = false;
+ // We can't say much about what network interfaces are available, but we can be pretty
+ // sure there's a loopback interface, and that it has IPv4, IPv6, and AF_PACKET entries.
+ ifaddrs* lo_inet4 = nullptr;
+ ifaddrs* lo_inet6 = nullptr;
+ ifaddrs* lo_packet = nullptr;
for (ifaddrs* addr = addrs; addr != nullptr; addr = addr->ifa_next) {
- if (addr->ifa_name && strcmp(addr->ifa_name, "lo") == 0) saw_loopback = true;
+ if (addr->ifa_name && strcmp(addr->ifa_name, "lo") == 0) {
+ if (addr->ifa_addr && addr->ifa_addr->sa_family == AF_INET) lo_inet4 = addr;
+ else if (addr->ifa_addr && addr->ifa_addr->sa_family == AF_INET6) lo_inet6 = addr;
+ else if (addr->ifa_addr && addr->ifa_addr->sa_family == AF_PACKET) lo_packet = addr;
+ }
}
- ASSERT_TRUE(saw_loopback);
+
+ // Does the IPv4 entry look right?
+ ASSERT_TRUE(lo_inet4 != nullptr);
+ const sockaddr_in* sa_inet4 = reinterpret_cast<const sockaddr_in*>(lo_inet4->ifa_addr);
+ ASSERT_TRUE(ntohl(sa_inet4->sin_addr.s_addr) == INADDR_LOOPBACK);
+
+ // Does the IPv6 entry look right?
+ ASSERT_TRUE(lo_inet6 != nullptr);
+ const sockaddr_in6* sa_inet6 = reinterpret_cast<const sockaddr_in6*>(lo_inet6->ifa_addr);
+ ASSERT_TRUE(IN6_IS_ADDR_LOOPBACK(&sa_inet6->sin6_addr));
+
+ // Does the AF_PACKET entry look right?
+ ASSERT_TRUE(lo_packet != nullptr);
+ const sockaddr_ll* sa_ll = reinterpret_cast<const sockaddr_ll*>(lo_packet->ifa_addr);
+ ASSERT_EQ(6, sa_ll->sll_halen);
freeifaddrs(addrs);
}