Fix mktime's errno behavior.
Don't touch errno on success, do set it to EOVERFLOW (the only allowed errno
value according to POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/functions/mktime.html)
on failure.
Bug: http://b/30477946
Change-Id: Ia915c7b9c3bfcd2f9025530cf5b068fe4dd4fd9e
diff --git a/tests/time_test.cpp b/tests/time_test.cpp
index 028a359..48c299a 100644
--- a/tests/time_test.cpp
+++ b/tests/time_test.cpp
@@ -102,20 +102,41 @@
#if !defined(__LP64__)
// 32-bit bionic stupidly had a signed 32-bit time_t.
ASSERT_EQ(-1, mktime(&t));
+ ASSERT_EQ(EOVERFLOW, errno);
#else
// Everyone else should be using a signed 64-bit time_t.
ASSERT_GE(sizeof(time_t) * 8, 64U);
setenv("TZ", "America/Los_Angeles", 1);
tzset();
+ errno = 0;
ASSERT_EQ(static_cast<time_t>(4108348800U), mktime(&t));
+ ASSERT_EQ(0, errno);
setenv("TZ", "UTC", 1);
tzset();
+ errno = 0;
ASSERT_EQ(static_cast<time_t>(4108320000U), mktime(&t));
+ ASSERT_EQ(0, errno);
#endif
}
+TEST(time, mktime_EOVERFLOW) {
+ struct tm t;
+ memset(&t, 0, sizeof(tm));
+ t.tm_year = 0;
+ t.tm_mon = 2;
+ t.tm_mday = 10;
+
+ errno = 0;
+ ASSERT_NE(static_cast<time_t>(-1), mktime(&t));
+ ASSERT_EQ(0, errno);
+
+ t.tm_year = INT_MAX;
+ ASSERT_EQ(static_cast<time_t>(-1), mktime(&t));
+ ASSERT_EQ(EOVERFLOW, errno);
+}
+
TEST(time, strftime) {
setenv("TZ", "UTC", 1);