fdtrack: make it clearer that there's more information available.
A lot of people who see these via pitot or whatever don't even think to look at the real tombstone. Make it explicit that this is what they should do next. Also, since we have the numbers, say exactly what we mean by "most common".
Bug: http://b/338882189
Change-Id: Ia21848a40e82cb2486538a7578501e2ec0948e1c
diff --git a/libfdtrack/fdtrack.cpp b/libfdtrack/fdtrack.cpp
index 57b9d37..3627c84 100644
--- a/libfdtrack/fdtrack.cpp
+++ b/libfdtrack/fdtrack.cpp
@@ -281,11 +281,13 @@
if (!stack) {
async_safe_format_buffer(buf, sizeof(buf),
- "aborting due to fd leak: failed to find most common stack");
+ "aborting due to fd leak: see \"open files\" in the tombstone; "
+ "no stacks?!");
} else {
char* p = buf;
p += async_safe_format_buffer(buf, sizeof(buf),
- "aborting due to fd leak: most common stack =\n");
+ "aborting due to fd leak: see \"open files\" in the tombstone; "
+ "most common stack (%zu/%zu) is\n", max, stacks.count);
for (size_t i = 0; i < stack->stack_depth; ++i) {
ssize_t bytes_left = buf + sizeof(buf) - p;