sem_timedwait with a null timeout doesn't mean "forever".
It actually means "crash immediately". Well, it's an error. And callers are
much more likely to realize their mistake if we crash immediately rather
than return EINVAL. Historically, glibc has crashed and bionic -- before
the recent changes -- returned EINVAL, so this is a behavior change.
Change-Id: I0c2373a6703b20b8a97aacc1e66368a5885e8c51
diff --git a/libc/bionic/pthread_rwlock.cpp b/libc/bionic/pthread_rwlock.cpp
index b1c48c8..a065295 100644
--- a/libc/bionic/pthread_rwlock.cpp
+++ b/libc/bionic/pthread_rwlock.cpp
@@ -298,7 +298,7 @@
if (result == 0 || result == EAGAIN) {
return result;
}
- result = check_timespec(abs_timeout_or_null);
+ result = check_timespec(abs_timeout_or_null, true);
if (result != 0) {
return result;
}
@@ -370,7 +370,7 @@
if (result == 0) {
return result;
}
- result = check_timespec(abs_timeout_or_null);
+ result = check_timespec(abs_timeout_or_null, true);
if (result != 0) {
return result;
}