Improve FORTIFY failure diagnostics.
Our FORTIFY _chk functions' implementations were very repetitive and verbose
but not very helpful. We'd also screwed up and put the SSIZE_MAX checks where
they would never fire unless you actually had a buffer as large as half your
address space, which probably doesn't happen very often.
Factor out the duplication and take the opportunity to actually show details
like how big the overrun buffer was, or by how much it was overrun.
Also remove the obsolete FORTIFY event logging.
Also remove the unused __libc_fatal_no_abort.
This change doesn't improve the diagnostics from the optimized assembler
implementations.
Change-Id: I176a90701395404d50975b547a00bd2c654e1252
diff --git a/libc/arch-arm/krait/bionic/memset.S b/libc/arch-arm/krait/bionic/memset.S
index ae05965..6b6d29c 100644
--- a/libc/arch-arm/krait/bionic/memset.S
+++ b/libc/arch-arm/krait/bionic/memset.S
@@ -28,7 +28,6 @@
#include <machine/cpu-features.h>
#include <private/bionic_asm.h>
-#include <private/libc_events.h>
/*
* This code assumes it is running on a processor that supports all arm v7
@@ -49,12 +48,9 @@
.cfi_rel_offset lr, 0
ldr r0, error_message
- ldr r1, error_code
1:
add r0, pc
- bl __fortify_chk_fail
-error_code:
- .word BIONIC_EVENT_MEMSET_BUFFER_OVERFLOW
+ bl __fortify_fatal
error_message:
.word error_string-(1b+8)
END(__memset_chk)