commit | a55f8b05879a61e7b1682ae919f08be40a70945e | [log] [tgz] |
---|---|---|
author | Jurijs Oniscuks <jurijs.oniscuks@sony.com> | Tue Aug 06 15:29:17 2024 +0200 |
committer | Cherrypicker Worker <android-build-cherrypicker-worker@google.com> | Fri Aug 23 12:32:24 2024 +0000 |
tree | a8f0fa40b1af384c51988798eece9af00e09b32e | |
parent | d7e16df3bfbe7201b13958244c54a31240f044ea [diff] |
Increase the space used by properties filenames The filename size for properties has 74 bytes overhead when used by CtsBionicTestCases testcases as they have this form: /data/local/tmp/TemporaryDir-fntJb8/appcompat_override/u:object_r:PROPERTY_NAME_prop:s0 With this overhead, a 128-byte filename size leaves only 53 bytes for property names. Longer names cause abort() in several test cases, e.g. __system_property_update(), resulting in CTS failures on some devices. Bring the size up to 256 bytes. Bug: 357631695 Test: run cts-dev -m CtsBionicTestCases -t properties#* Fixes: I524d7e5ffd415ba0c3d600eb94801a304b1b4bb4 (cherry picked from https://android-review.googlesource.com/q/commit:b497cc98ec68b9f7f45b89a60fd5d0a7aaf08394) Merged-In: Ic93c2ea28eed2f5f392cc8fe366ed10eb6dcac6b Change-Id: Ic93c2ea28eed2f5f392cc8fe366ed10eb6dcac6b
diff --git a/libc/system_properties/include/system_properties/properties_filename.h b/libc/system_properties/include/system_properties/properties_filename.h index d686f20..743d291 100644 --- a/libc/system_properties/include/system_properties/properties_filename.h +++ b/libc/system_properties/include/system_properties/properties_filename.h
@@ -46,6 +46,8 @@ const char* c_str() { return filename_; } private: - // Typically something like "/dev/__properties__/properties_serial". - char filename_[128]; + // Typically something like "/dev/__properties__/properties_serial", but can be as long as + // "/data/local/tmp/TemporaryDir-fntJb8/appcompat_override/u:object_r:PROPERTY_NAME_prop:s0" + // when running CTS. + char filename_[256]; };