Global clang-tidy is dead, and not coming back.
Change-Id: Ia24568e9908ac88fb72f45c0b2e7f50101a6fb00
diff --git a/libc/Android.bp b/libc/Android.bp
index d914983..c214198 100644
--- a/libc/Android.bp
+++ b/libc/Android.bp
@@ -104,8 +104,6 @@
},
apex_available: ["com.android.runtime"],
-
- tidy_disabled_srcs: ["upstream-*/**/*.c"],
}
// Workaround for b/24465209.
diff --git a/libc/malloc_debug/Android.bp b/libc/malloc_debug/Android.bp
index 5d61801..add6ba9 100644
--- a/libc/malloc_debug/Android.bp
+++ b/libc/malloc_debug/Android.bp
@@ -182,11 +182,6 @@
"bionic_libc_platform_headers",
],
- // The clang-analyzer-unix.Malloc and other warnings in these
- // unit tests are either false positive or in
- // negative tests that can be ignored.
- tidy: false,
-
srcs: [
"tests/malloc_debug_system_tests.cpp",
],
diff --git a/libc/malloc_hooks/Android.bp b/libc/malloc_hooks/Android.bp
index 3f0640b..06e91c6 100644
--- a/libc/malloc_hooks/Android.bp
+++ b/libc/malloc_hooks/Android.bp
@@ -60,11 +60,6 @@
name: "malloc_hooks_system_tests",
isolated: true,
- // The clang-analyzer-unix.Malloc and other warnings in these
- // unit tests are either false positive or in
- // negative tests that can be ignored.
- tidy: false,
-
srcs: [
"tests/malloc_hooks_tests.cpp",
],
diff --git a/libm/Android.bp b/libm/Android.bp
index ee86959..69cfb14 100644
--- a/libm/Android.bp
+++ b/libm/Android.bp
@@ -32,7 +32,6 @@
whole_static_libs: ["libarm-optimized-routines-math"],
- tidy_disabled_srcs: ["upstream-*/**/*.c"],
srcs: [
"upstream-freebsd/lib/msun/bsdsrc/b_tgamma.c",
"upstream-freebsd/lib/msun/src/catrig.c",
@@ -404,9 +403,6 @@
"-Wl,--Bsymbolic-functions",
],
- // b/120614316, non-critical readibility check
- tidy_checks: ["-cert-dcl16-c"],
-
include_dirs: ["bionic/libc"],
target: {
bionic: {
diff --git a/tests/Android.bp b/tests/Android.bp
index f227bbc..e2ac09a 100644
--- a/tests/Android.bp
+++ b/tests/Android.bp
@@ -379,9 +379,6 @@
"bionic_tests_defaults",
"large_system_property_node_defaults",
],
- tidy_disabled_srcs: [
- "malloc_test.cpp", // timed out with clang-tidy, and too many warnings
- ],
srcs: [
"__aeabi_read_tp_test.cpp",
"__cxa_atexit_test.cpp",
@@ -657,7 +654,6 @@
static_libs: [
"libbase",
],
- tidy: false,
target: {
musl: {
// Musl doesn't have fortify
@@ -666,12 +662,12 @@
},
}
-// Ensure we don't use FORTIFY'ed functions with the static analyzer/clang-tidy:
+// Ensure we don't use FORTIFY'ed functions with the clang static analyzer:
// it can confuse these tools pretty easily. If this builds successfully, then
// __clang_analyzer__ overrode FORTIFY. Otherwise, FORTIFY was incorrectly
// enabled. The library that results from building this is meant to be unused.
cc_test_library {
- name: "fortify_disabled_for_tidy",
+ name: "fortify_disabled_for_clang_analyzer",
defaults: [
"bionic_clang_fortify_tests_w_flags",
],
@@ -681,7 +677,6 @@
"-D__clang_analyzer__",
],
srcs: ["clang_fortify_tests.cpp"],
- tidy: false,
}
cc_test_library {
@@ -723,7 +718,6 @@
"-U_FORTIFY_SOURCE",
],
srcs: ["clang_fortify_tests.cpp"],
- tidy: false,
}
cc_test_library {
@@ -772,7 +766,6 @@
srcs: [
"clang_fortify_c_only_tests.c",
],
- tidy: false,
shared: {
enabled: false,
},
@@ -1428,7 +1421,6 @@
enabled: true,
},
},
- tidy: false,
clang_verify: true,
cflags: [
"-Wall",