Add ASSERT_ERRNO and EXPECT_ERRNO (and use them).
We've talked about this many times in the past, but partners struggle to
understand "expected 38, got 22" in these contexts, and I always have to
go and check the header files just to be sure I'm sure.
I actually think the glibc geterrorname_np() function (which would
return "ENOSYS" rather than "Function not implemented") would be more
helpful, but I'll have to go and implement that first, and then come
back.
Being forced to go through all our errno assertions did also make me
want to use a more consistent style for our ENOSYS assertions in
particular --- there's a particularly readable idiom, and I'll also come
back and move more of those checks to the most readable idiom.
I've added a few missing `errno = 0`s before tests, and removed a few
stray `errno = 0`s from tests that don't actually make assertions about
errno, since I had to look at every single reference to errno anyway.
Test: treehugger
Change-Id: Iba7c56f2adc30288c3e00ade106635e515e88179
diff --git a/tests/termios_test.cpp b/tests/termios_test.cpp
index a8d5890..480f3af 100644
--- a/tests/termios_test.cpp
+++ b/tests/termios_test.cpp
@@ -34,6 +34,8 @@
#include <gtest/gtest.h>
+#include "utils.h"
+
// TODO:
// tcdrain
// tcflow
@@ -53,7 +55,7 @@
termios t = {};
errno = 0;
ASSERT_EQ(-1, cfsetispeed(&t, 1200));
- ASSERT_EQ(EINVAL, errno);
+ ASSERT_ERRNO(EINVAL);
}
TEST(termios, cfgetospeed_cfsetospeed) {
@@ -66,7 +68,7 @@
termios t = {};
errno = 0;
ASSERT_EQ(-1, cfsetospeed(&t, 1200));
- ASSERT_EQ(EINVAL, errno);
+ ASSERT_ERRNO(EINVAL);
}
TEST(termios, cfsetspeed) {
@@ -82,7 +84,7 @@
// glibc seems to allow 1200 as well as B1200 here, presumably for
// BSD compatibility (where Bxxx == xxx, unlike Linux).
ASSERT_EQ(-1, cfsetspeed(&t, 123));
- ASSERT_EQ(EINVAL, errno);
+ ASSERT_ERRNO(EINVAL);
}
TEST(termios, cfmakeraw) {
@@ -105,11 +107,11 @@
errno = 0;
ASSERT_EQ(-1, tcgetwinsize(-1, &ws));
- ASSERT_EQ(EBADF, errno);
+ ASSERT_ERRNO(EBADF);
errno = 0;
ASSERT_EQ(-1, tcsetwinsize(-1, &ws));
- ASSERT_EQ(EBADF, errno);
+ ASSERT_ERRNO(EBADF);
#else
GTEST_SKIP() << "glibc too old";
#endif