commit 7efad83d430f4d824f2aaa75edea5106f6ff8aae
author Elliott Hughes <enh@google.com> Mon Sep 08 15:25:01 2014 -0700
committer Elliott Hughes <enh@google.com> Mon Sep 08 15:36:21 2014 -0700
tree 5bc18249730f5d714eb12b877db4a601ed96fefe
parent c8f6b82f87d9e4ea385ce6d634220b369b76845a

Ensure __set_errno is still visible on LP32.

The use of the .hidden directive to avoid going via the PLT for
__set_errno had the side-effect of actually making __set_errno
hidden (which is odd because assembler directives don't usually
affect symbols defined in a different file --- you can't even
create a weak reference to a symbol that's defined in a different
file).

This change switches the system call stubs over to a new always-hidden
__set_errno_internal and has a visible __set_errno on LP32 just for
binary compatibility with old NDK apps.

Bug: 17423135
Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b

libc/arch-arm/bionic/syscall.S

diff --git a/libc/arch-arm/bionic/syscall.S b/libc/arch-arm/bionic/syscall.S
index 8647718..d0df379 100644
--- a/libc/arch-arm/bionic/syscall.S
+++ b/libc/arch-arm/bionic/syscall.S
@@ -47,5 +47,5 @@
     cmn     r0, #(MAX_ERRNO + 1)
     bxls    lr
     neg     r0, r0
-    b       __set_errno
+    b       __set_errno_internal
 END(syscall)