commit 6feec2c5f69b5b6dc06fbe3dee562a59ae2a0e9c
author Elliott Hughes <enh@google.com> Wed Feb 19 10:29:31 2025 -0800
committer Elliott Hughes <enh@google.com> Wed Feb 19 10:29:31 2025 -0800
tree 8ef9e93b018401a8f8ea27412b762d1cb8c6c780
parent fffdee596f8555705ec8767b9c8391b7d2fa127c

Clarify that the has_min_version() is ILP32-only.

It always returns true on LP64, so call it is_lp64_or_has_min_version() instead.

Change-Id: Icd11e34117be6a134c1b2854276a75d105356f90

linker/linker.cpp

diff --git a/linker/linker.cpp b/linker/linker.cpp
index 2393f13..2db6e81 100644
--- a/linker/linker.cpp
+++ b/linker/linker.cpp
@@ -346,7 +346,7 @@
     }
   }
 
-  if (si->has_min_version(6) && si->get_gap_size()) {
+  if (si->is_lp64_or_has_min_version(6) && si->get_gap_size()) {
     munmap(reinterpret_cast<void*>(si->get_gap_start()), si->get_gap_size());
   }
 
@@ -1907,7 +1907,7 @@
 
     local_unload_list.push_back(si);
 
-    if (si->has_min_version(0)) {
+    if (si->is_lp64_or_has_min_version(0)) {
       soinfo* child = nullptr;
       while ((child = si->get_children().pop_front()) != nullptr) {
         LD_DEBUG(any, "%s@%p needs to unload %s@%p", si->get_realpath(), si,
@@ -2671,7 +2671,7 @@
 
 template <typename F>
 static bool for_each_verdef(const soinfo* si, F functor) {
-  if (!si->has_min_version(2)) {
+  if (!si->is_lp64_or_has_min_version(2)) {
     return true;
   }
 
@@ -2762,7 +2762,7 @@
 }
 
 bool VersionTracker::init(const soinfo* si_from) {
-  if (!si_from->has_min_version(2)) {
+  if (!si_from->is_lp64_or_has_min_version(2)) {
     return true;
   }