commit 5cec377f49d6429b19895eb632225cd757ea611e
author Elliott Hughes <enh@google.com> Fri Jan 19 15:45:23 2018 -0800
committer Elliott Hughes <enh@google.com> Fri Jan 19 15:56:12 2018 -0800
tree bcd08fe1e6b656a5a4e235a225fbe88feb54a112
parent 0d63a3c233040af004cc470d5f76547f3adc0148

Address a bunch of clang-tidy complaints.

There were a bunch more unreasonable/incorrect ones, but these ones
seemed legit. Nothing very interesting, though.

Bug: N/A
Test: ran tests, benchmarks
Change-Id: If66971194d4a7b4bf6d0251bedb88e8cdc88a76f

libc/bionic/icu.cpp

diff --git a/libc/bionic/icu.cpp b/libc/bionic/icu.cpp
index 78e551b..c09c9ea 100644
--- a/libc/bionic/icu.cpp
+++ b/libc/bionic/icu.cpp
@@ -68,7 +68,7 @@
   }
   free(namelist);
 
-  if (max_version == -1 || max_version < ICUDATA_VERSION_MIN) {
+  if (max_version < ICUDATA_VERSION_MIN) {
     async_safe_write_log(ANDROID_LOG_ERROR, "bionic-icu", "couldn't find an ICU .dat file");
     return false;
   }