commit 53ddcc90701d86c7d809a84cf4710c651066e3c7
author Nick Kralevich <nnk@google.com> Fri Jun 21 22:36:50 2013 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Jun 21 22:36:50 2013 +0000
tree 3034d0cab47807e06a4d0ff17d3ad4b555753cb5
parent 6819773103495a6fd81f024dc6711771320ae4ec
parent c9084427aa15259c8bfb9b13b979597a4abd1805

Merge "linker: Emit a warning on text relocations"

linker/linker.cpp

diff --git a/linker/linker.cpp b/linker/linker.cpp
index c53d52f..9c35cfc 100644
--- a/linker/linker.cpp
+++ b/linker/linker.cpp
@@ -1533,6 +1533,8 @@
          * phdr_table_protect_segments() after all of them are applied
          * and all constructors are run.
          */
+        DL_WARN("%s has text relocations. This is wasting memory and is "
+                "a security risk. Please fix.", si->name);
         if (phdr_table_unprotect_segments(si->phdr, si->phnum, si->load_bias) < 0) {
             DL_ERR("can't unprotect loadable segments for \"%s\": %s",
                    si->name, strerror(errno));