Remove the libm-global `#pragma STDC FENV_ACCESS ON` hammer.
This was added to avoid test failures (see https://b.corp.google.com/issues/149839606#comment40) running 32-bit test binaries built for a 64-bit x86_64 target:
```
[==========] Running 2 tests from 2 test suites (2 jobs).
[ RUN ] math_h_force_long_double.roundl
bionic/tests/math_test.cpp:(1227) Failure in test math_h_force_long_double.roundl
Expected equality of these values:
1.0L
Which is: 1
roundl(0.5L)
Which is: 0
math_h_force_long_double.roundl exited with exitcode 1.
[ FAILED ] math_h_force_long_double.roundl (6 ms)
[ RUN ] math_h.roundl
bionic/tests/math_test.cpp:(1227) Failure in test math_h.roundl
Expected equality of these values:
1.0L
Which is: 1
roundl(0.5L)
Which is: 0
math_h.roundl exited with exitcode 1.
[ FAILED ] math_h.roundl (7 ms)
[==========] 2 tests from 2 test suites ran. (9 ms total)
```
Those tests (built and tested in that configuration) work for me today, and objdump shows that we are actually calling the libm routines rather than inlining a roundl() implementation into the test.
Change-Id: If3fea193d9b84b6b00ca9da667cbdc2a143bb0b2
diff --git a/libm/Android.bp b/libm/Android.bp
index fa43a16..9adf9f1 100644
--- a/libm/Android.bp
+++ b/libm/Android.bp
@@ -391,7 +391,6 @@
"-D_BSD_SOURCE",
"-DFLT_EVAL_METHOD=0",
"-include freebsd-compat.h",
- "-include fenv-access.h",
"-fno-builtin",
"-fno-math-errno",
"-Wall",
diff --git a/libm/fenv-access.h b/libm/fenv-access.h
deleted file mode 100644
index 7acb34d..0000000
--- a/libm/fenv-access.h
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Copyright (C) 2021 The Android Open Source Project
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in
- * the documentation and/or other materials provided with the
- * distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
- * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
- * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
- * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
- * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
- * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
- */
-
-#pragma once
-
-#if defined(__x86_64__) || defined(__i386__)
-#pragma STDC FENV_ACCESS ON
-#endif