commit 315969a67eb09607f278cd17ae1637bbf661a559
author Ryan Prichard <rprichard@google.com> Wed Jan 13 20:34:32 2021 -0800
committer Ryan Prichard <rprichard@google.com> Thu Jan 14 17:33:38 2021 -0800
tree 55b54735235e3b189ba58e885814e5b429ef84c3
parent b4fd07297606de111c10d0f9a000fdb1e2280387

Disable signal frame unwinding tests on arm64

The current libunwind.a LLVM prebuilt lacks the special arm64 signal
frame unwinder (https://reviews.llvm.org/D90898), so disable the signal
frame unwinding tests temporarily. (It's not clear who needs this
functionality on Android -- typically crash dumping should use
libunwindstack instead of _Unwind_Backtrace.)

Bug: http://b/153025717
Test: bionic unit tests
Change-Id: I36644dfe4acbedd937768c3aaaad1010099d602c

tests/stack_unwinding_test.cpp

diff --git a/tests/stack_unwinding_test.cpp b/tests/stack_unwinding_test.cpp
index 0ff6f30..7fb2247 100644
--- a/tests/stack_unwinding_test.cpp
+++ b/tests/stack_unwinding_test.cpp
@@ -82,7 +82,7 @@
 
 static UnwindData g_unwind_data;
 
-static void noinline UnwindSignalHandler(int) {
+__attribute__((unused)) static void noinline UnwindSignalHandler(int) {
   _Unwind_Backtrace(FrameCounter, &g_unwind_data.handler_frame_count);
 
   g_unwind_data.handler_one_deeper_frame_count = unwind_one_frame_deeper();
@@ -98,7 +98,7 @@
   EXPECT_EQ(unwind_data.handler_frame_count + 1, unwind_data.handler_one_deeper_frame_count);
 }
 
-static void noinline UnwindTest() {
+__attribute__((unused)) static void noinline UnwindTest() {
   g_unwind_data = {};
 
   _Unwind_Backtrace(FrameCounter, &g_unwind_data.expected_frame_count);
@@ -112,14 +112,24 @@
 }
 
 TEST(stack_unwinding, unwind_through_signal_frame) {
+#if defined(__aarch64__)
+  // A newer libunwind.a update should restore signal frame unwinding on arm64.
+  GTEST_SKIP() << "signal frame unwinding temporarily broken on arm64 -- b/153025717";
+#else
   ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler);
 
   UnwindTest();
+#endif
 }
 
 // On LP32, the SA_SIGINFO flag gets you __restore_rt instead of __restore.
 TEST(stack_unwinding, unwind_through_signal_frame_SA_SIGINFO) {
+#if defined(__aarch64__)
+  // A newer libunwind.a update should restore signal frame unwinding on arm64.
+  GTEST_SKIP() << "signal frame unwinding temporarily broken on arm64 -- b/153025717";
+#else
   ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler, SA_SIGINFO);
 
   UnwindTest();
+#endif
 }