commit 2d3122c90b58655cc44c9e7b9461b9de3daccb2e
author Yi Kong <yikong@google.com> Sun Apr 30 15:08:05 2017 -0700
committer Yi Kong <yikong@google.com> Tue May 02 21:14:42 2017 +0000
tree 2ec2c29d0fff6cb4cb54da35ff4f1abe92b67292
parent dfe0fa4151eeae806e9eb52c337c449cd028c160

Fix test compile errors after LLVM rebase

After the new rebase of Clang, we now support the alloc_size attribute,
so we can remove the warning about switching to alloc_size once Clang
has support.

Also fix an issue where 'false' is returned in a main method.

Test: make cts
Bug: 37752547
Change-Id: I32ee814aaa0338567cb8174a68d7ee1bfece2f75

tests/fortify_test.cpp

diff --git a/tests/fortify_test.cpp b/tests/fortify_test.cpp
index 67103e1..2835f1d 100644
--- a/tests/fortify_test.cpp
+++ b/tests/fortify_test.cpp
@@ -407,11 +407,8 @@
   ASSERT_FORTIFY(sprintf(buf, "%s", source_buf));
 }
 
-#ifdef __clang__
-// Exists upstream, but hasn't been pulled in yet.
-#if __has_attribute(alloc_size)
-#error "Reenable this test"
-#endif
+#ifdef __clang__ && !__has_attribute(alloc_size)
+// TODO: remove this after Clang prebuilt rebase.
 #else
 // This test is disabled in clang because clang doesn't properly detect
 // this buffer overflow. TODO: Fix clang.

tests/libs/bionic_tests_zipalign.cpp

diff --git a/tests/libs/bionic_tests_zipalign.cpp b/tests/libs/bionic_tests_zipalign.cpp
index 8e31474..56183ba 100644
--- a/tests/libs/bionic_tests_zipalign.cpp
+++ b/tests/libs/bionic_tests_zipalign.cpp
@@ -142,7 +142,7 @@
   if (return_value != 0) {
     CloseArchive(handle);
     fprintf(stderr, "Unable to open '%s': %s\n", argv[2], ErrorCodeString(return_value));
-    return false;
+    return 1;
   }
 
   FILE* zip_dst = fopen(argv[3], "we");