commit 27914298f5d277a6f202bfc0b860a010cb8b1676
author Florian Mayer <fmayer@google.com> Mon Aug 01 15:02:25 2022 -0700
committer Florian Mayer <fmayer@google.com> Mon Aug 01 15:02:47 2022 -0700
tree cc63bf4780b587bab9d0d52384b1c18896f64000
parent 4ebdeebef74ffa09fe8176f73b32d5a21f4be4ae

[MTE] use static buffer for per-process property name.

Change-Id: I3b0d0fdffe72aef7d66544fecac18f7a097ddbaf

libc/bionic/libc_init_static.cpp

diff --git a/libc/bionic/libc_init_static.cpp b/libc/bionic/libc_init_static.cpp
index 66aaeaa..36c61e8 100644
--- a/libc/bionic/libc_init_static.cpp
+++ b/libc/bionic/libc_init_static.cpp
@@ -224,17 +224,14 @@
 
   const char* basename = __gnu_basename(progname);
 
-  static constexpr size_t kOptionsSize = PROP_VALUE_MAX;
-  char options_str[kOptionsSize];
-  size_t sysprop_size = strlen(basename) + strlen(kMemtagPrognameSyspropPrefix) + 1;
-  char* sysprop_name = static_cast<char*>(alloca(sysprop_size));
-
-  async_safe_format_buffer(sysprop_name, sysprop_size, "%s%s", kMemtagPrognameSyspropPrefix,
+  char options_str[PROP_VALUE_MAX];
+  char sysprop_name[512];
+  async_safe_format_buffer(sysprop_name, sizeof(sysprop_name), "%s%s", kMemtagPrognameSyspropPrefix,
                            basename);
   const char* sys_prop_names[] = {sysprop_name, kMemtagGlobalSysprop};
 
   if (!get_config_from_env_or_sysprops("MEMTAG_OPTIONS", sys_prop_names, arraysize(sys_prop_names),
-                                       options_str, kOptionsSize)) {
+                                       options_str, sizeof(options_str))) {
     return false;
   }