fortify: replace bzero/bcmp defines
__builtin_*_chk will emit warnings when things are trivially broken.
Emitting errors instead is probably better (and we can be a bit smarter
about how we emit code for trivially safe cases.)
Bug: 131861088
Test: checkbuild + bionic-unit-tests on blueline
Change-Id: I33957ad419922d0760304758ecb9bc8ad33e0b64
diff --git a/tests/clang_fortify_tests.cpp b/tests/clang_fortify_tests.cpp
index 291fc5a..1b6b898 100644
--- a/tests/clang_fortify_tests.cpp
+++ b/tests/clang_fortify_tests.cpp
@@ -165,10 +165,9 @@
EXPECT_FORTIFY_DEATH(memset(small_buffer, 0, sizeof(large_buffer)));
// expected-warning@+1{{arguments got flipped?}}
EXPECT_NO_DEATH(memset(small_buffer, sizeof(small_buffer), 0));
- // FIXME: Should these be warnings?
- // expected-warning@+1{{will always overflow}}
+ // expected-error@+1{{size bigger than buffer}}
EXPECT_FORTIFY_DEATH(bcopy(large_buffer, small_buffer, sizeof(large_buffer)));
- // expected-warning@+1{{will always overflow}}
+ // expected-error@+1{{size bigger than buffer}}
EXPECT_FORTIFY_DEATH(bzero(small_buffer, sizeof(large_buffer)));
}